Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I receive the following error when I attempt to access /access_token without an expires parameter:
Notice: Undefined index: expires in oauth_common_callback_access_token() (line 359 of /var/www/drupal/sites/all/modules/oauth/oauth_common.pages.inc).
I'm not sure how to submit a patch. If you change line 359 referred above to include an isset(), it seems to work:
if (isset($_GET['expires']) && intval($_GET['expires'])) {
Comment | File | Size | Author |
---|---|---|---|
#5 | oauth-php_notices_expire_value-1404030-5.patch | 1.08 KB | h3rj4n |
#2 | 1404030-2.patch | 1.15 KB | pwolanin |
#1 | 1404030-1.oauth-notices.patch | 1.15 KB | ksenzee |
Comments
Comment #1
ksenzeeI was writing some simpletests for our oauth flow and ran into this notice, as well as an "Undefined index: query" notice that's emitted on line 121 of oauth_common.pages.inc if the callback URL for your oauth consumer doesn't include a query string.
Comment #2
pwolanin CreditAttribution: pwolanin commentedPatch needed a re-roll.
verified that it fixes the notices.
Comment #3
juampynr CreditAttribution: juampynr commentedCommitted to 7.x-3.x. Thanks!
http://drupalcode.org/project/oauth.git/commitdiff/3211e05
Comment #4
rjbrown99 CreditAttribution: rjbrown99 commentedUpdating to proper status per issue queue handbook.
Comment #5
h3rj4n CreditAttribution: h3rj4n commentedI couldn't apply the patch because it's for D7. I added by hand and created patch for it.
Comment #6
DamienMcKennaThe patch in #5 needs to be rerolled.
Comment #8
kyletaylored CreditAttribution: kyletaylored at LevelTen Interactive commentedI was updating this module on one of our sites, used a previous patch, and after looking at the 7.x-3.x branch, the patch in #5 has already been applied and committed in the latest release. Given it's also 4 years old, I'm gonna mark this as fixed.
Comment #10
zhouhana CreditAttribution: zhouhana as a volunteer commentedI can't read PHP very well myself, so I just want to double check. Because of the recent security release to OAuth I'm trying to update the module for a few sites, and now I'd like to reapply the patches that were previously applied, so the sites don't lose any important functionality.
The release notes for OAuth say nothing about this patch being included in the non-dev branch, but still when I try to apply it through the command line I get this:
Does this mean it is already in the 7.x-3.3 branch after all?
Comment #11
ksenzeeYes - see comment #3. The patch is in the 7.x-3.x branch. (7.x-3.3 is a tag off the 7.x-3.x branch.) So no worries. Thanks for checking!
Comment #12
zhouhana CreditAttribution: zhouhana as a volunteer commentedGreat! Thank you!