Problem/Motivation

In #375397: Make Node module optional we forgot about field_attach_delete_bundle() in node_uninstall(), as decided in #1115510: Entity providing modules must call field_attach_delete_bundle() in hook_uninstall().

Proposed resolution

Commit the patch from #1? :)

CommentFileSizeAuthor
#4 1403136-4.patch2.19 KBamateescu
#1 1403136.patch516 bytesamateescu

Comments

amateescu’s picture

Version: 7.x-dev » 8.x-dev
Status: Active » Needs review
StatusFileSize
new516 bytes

And the patch.

sun’s picture

Issue tags: +Needs tests

The reason we missed it is that it's not covered by tests, so that needs to be fixed in here as well ;)

yched’s picture

Issue tags: -Needs tests

I'll let sun ping back, but that seems needed.

amateescu’s picture

Issue tags: +Needs tests
StatusFileSize
new2.19 KB

Copied the test from taxonomy, but it seems to fail even with the fix applied. Are we missing something else here?

The last submitted patch, 1403136-4.patch, failed testing.

sushyl’s picture

Assigned: Unassigned » sushyl
Issue summary: View changes
xjm’s picture

Component: node.module » node system

(Merging "node system" and "node.module" components for 8.x; disregard.)

sushyl’s picture

Status: Needs work » Fixed
Related issues: +#2294083: Remove usages of module_uninstall()

hook_uninstall has been removed per Module/hook system functions replaced with module_handler and module_installer service. So this issue is not applicable now.

sushyl’s picture

Assigned: sushyl » Unassigned
sushyl’s picture

Issue tags: -Needs tests +#drupalgoa2015
berdir’s picture

Status: Fixed » Closed (cannot reproduce)

hook_uninstall() still exists, so the reasoning is not correct, but yes, it is no longer possible to uninstall node.module without deleting the node types first.

Changing to cannot reproduce, because the relevant code no longer exists, I think that's the best match.