The uninstall hook does not delete per content type variables when uninstalling the module

For example, the following settings will remain once Annotate is gone.

annotate_allow_page: 1
annotate_display_expanded_page: "0"
annotate_allow_multiple_page: 0
annotate_display_multi_expanded_page: "0"
annotate_default_visibility_page: "0"
annotate_visibility_force_page: 1
CommentFileSizeAuthor
#1 annotate_uninstall--1.patch953 bytespau1_m

Comments

pau1_m’s picture

pau1_m commented
Status: Active » Needs review
StatusFileSize
new annotate_uninstall--1.patch953 bytes

Here's a patch

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Needs review » Needs work 
+++ b/annotate.install
@@ -122,9 +122,20 @@ function annotate_install() {
+  $content_types = node_get_types();
+  ¶
+  foreach ($content_types as $content_type) {

Replace with

foreach (node_get_types() as $type => $info) {

[ Powered by #1115636: Issue Macros and Templates - _default]

The code has whitespace problems. Please use http://drupal.org/project/coder to check your code.

Please fix the reported issues. Don't forget to set status to needs review when submitting a new patch.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Issue summary: View changes

missed out 'not' completely changing meaning of sentence.