Closed (fixed)
Project:
D7 Media
Version:
7.x-2.x-dev
Component:
Media Browser
Priority:
Major
Category:
Task
Assigned:
Reporter:
Created:
10 Jan 2012 at 21:35 UTC
Updated:
27 Mar 2012 at 23:00 UTC
Jump to comment: Most recent file
We need to clean-up our current implementation of the media browser plugins:
Before:
$plugins['upload'] = array(
'title' => t('Upload'),
'weight' => -10,
'handler' => array(
'path' => drupal_get_path('module', 'media') . '/includes',
'file' => 'MediaBrowserUpload.inc',
'class' => 'MediaBrowserUpload',
),
'access callback' => 'media_access',
'access arguments' => array('edit'),
);
After:
$plugins['upload'] = array(
'title' => t('Upload'),
'weight' => -10,
'class' => 'MediaBrowserUpload',
);
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 1400200-media-browser-plugin-cleanup-part3.patch | 10.89 KB | dave reid |
| #6 | 1400200-media-browser-plugin-cleanup-part2.patch | 11.83 KB | dave reid |
| #2 | 1400200-media-browser-plugin-cleanup.patch | 9.5 KB | dave reid |
Comments
Comment #1
dave reidComment #2
dave reidFirst phase: implement the first part: stop using CTools plugin system.
Comment #3
dave reidPatch in #2 has been committed to Git.
http://drupalcode.org/project/media.git/commit/8670623
Comment #4
damienmckennaI think that means it's fixed? :)
Comment #5
dave reidNo, I still have to address parts 2-4 of the original issue now. :)
Comment #6
dave reidPart 2, defining a proper interface and an abstract class.
Comment #7
dave reidTested #6 to pushed to Git: http://drupalcode.org/project/media.git/commit/3665957
Comment #8
dave reidHere's part three which implements MediaBrowserPluginInterface::access() on all the tabs. Also helps cleanup the Views tab code by re-using $this->view.
Comment #9
dave reidCommitted phase three with http://drupalcode.org/project/media.git/commit/0c3e982. I'm going to consider this fixed for now. I'll make a separate issue for the MediaBrowserMenuPath plugin.