Problem/Motivation

Proposed resolution

  • Move this test method into the child class CommentInterfaceTest.
CommentFileSizeAuthor
#7 d7-1399896-no-whitespace.patch5.24 KBxjm
#6 d7-1399896.patch5.22 KBxjm
move-new-count-test.patch5.29 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Title: testCommentNewCommentsIndicator() is inside CommentHelperCase and therefore does not get run » testCommentNewCommentsIndicator() is inside CommentHelperCase and therefore gets run repeatedly

Yeah, more coffee.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Needs backport to D7

And yeah.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Yeah the CommentHelperCase shouldn't contain tests

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Funky. Good spot!

catch’s picture

catch
he/him
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Craziness.

Committed/pushed to 8.x, moving back to 7.x for backport.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Patch (to be ported) » Reviewed & tested by the community
StatusFileSize
new d7-1399896.patch5.22 KB
xjm’s picture

xjm
she/her
Primary language English
commented
StatusFileSize
new d7-1399896-no-whitespace.patch5.24 KB

Without an extra line of whitespace that wasn't in the original patch. :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

LOL. Nice find.

Committed and pushed to 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updated issue summary.