Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
- The testCommentNewCommentsIndicator() method is inside
CommentHelperCase
and is therefore run repeatedly for every comment test case.
Proposed resolution
- Move this test method into the child class
CommentInterfaceTest
.
Comment | File | Size | Author |
---|---|---|---|
#7 | d7-1399896-no-whitespace.patch | 5.24 KB | xjm |
#6 | d7-1399896.patch | 5.22 KB | xjm |
move-new-count-test.patch | 5.29 KB | xjm | |
Comments
Comment #1
xjmYeah, more coffee.
Comment #2
xjmAnd yeah.
Comment #3
aspilicious CreditAttribution: aspilicious commentedYeah the CommentHelperCase shouldn't contain tests
Comment #4
sunFunky. Good spot!
Comment #5
catchCraziness.
Committed/pushed to 8.x, moving back to 7.x for backport.
Comment #6
xjmComment #7
xjmWithout an extra line of whitespace that wasn't in the original patch. :)
Comment #8
webchickLOL. Nice find.
Committed and pushed to 7.x. Thanks!
Comment #9.0
(not verified) CreditAttribution: commentedUpdated issue summary.