Change names on widget buttons, incl. removing the media tail

Postponing until #1213252: Allow media file's fields to be edited in a modal or after upload in the media widget lands.

I'm mostly in favor of this, although I think it would be good to rename 'Select' for a record that has an existing file to 'Replace'?

Changed the labels like so...
Select Media = Replace
Edit Media = Edit
Remove media = Remove
... and when there's no file yet for the element, you get Choose instead of "Replace". See screenshot, patch attached.

After #1452832: What is the best way to modify the buttons in the media widget? and unstable6, the patch at #4 no longer applies. Here's another if you think simpler language is good for defaults. But as that issue points out, this is now easily overridden by well-placed alter hooks.

Works beautifully, thanks! Just a general note, one-word buttons tend to work better in english anyway, in that the button text on smaller screens (or when the widget is placed inside a two column layout) doesn't wrap to two lines.

Patch applies cleanly on 2.x, works as advertized

+++ b/media.moduleundefined
@@ -917,11 +917,13 @@ function media_element_process(&$element, &$form_state, $form) {
-    '#title' => t('Select media'),
+    '#title' => $file ? t('Replace') : t('Choose'),

Maybe Add is better than Choose?

That should probably be ! empty($file) ? t('Replace') : t('Choose') to not throw a php warning

$file is always set (see here)
$file = $fid ? file_load($fid) : FALSE;

Woops, sorry, only read the patch there. We can probably change this line then:

  $element['preview'] = array(
    '#prefix' => '<div class="preview launcher">', 
    '#suffix' => '</div>', 
    '#weight' => 0, 
    'content' => !empty($file) ? media_get_thumbnail_preview($file) : array(),
  );

obviously not necessary but keeps things a bit neater.

i seriously dont like choose..select or add is far more better

I agree with rootatwc on select. We should also pay attention to this issue as well: http://drupal.org/node/1807832

Rerolled patch with request from rootatwc

Setting correct status

Thanks for rerolling this arthur..
i think its ready now

commited
http://drupalcode.org/project/media.git/commit/06d0a36

Thanks

Given that this change will break translations, do we want to backport it?

1 thing i did just notice is the 'add' button changed somewhere, but not sure if that's related / where it was 'introduced':

• Add content type + file / media selector.
• Add a node with an image and save the node.
• Then edit the node, hit the 'Remove' button next to the media.

The 'Add' button now reads 'Replace'. Just a minor thing.

Yeah this is why keeping 'Select' would have been nice. If we have Add vs Replace you have two swap out the text using JavaScript. Swapping it out via JavaScript means that you are no longer able to override the button text since the strings are hard-coded in the JS, or you'd need to provide the text in a data attribute of the button, which at that point seems like we're just adding unnecessary complexity.

agreed

Works as advertised, looks good to me!

Committed http://drupalcode.org/project/media.git/commit/e94ee0a