The newsletter footer is never included in newsletter emails

This is reasonably recent as when I updated for fix a different bug this regressed.

CommentFileSizeAuthor
#6 fix_footer_fix_and_add_tests.patch1.87 KBberdir
#1 simplenews-footer_missing-1398208-1.patch495 bytesrooby

Comments

rooby’s picture

rooby commented
Status: Active » Needs review
StatusFileSize
new simplenews-footer_missing-1398208-1.patch495 bytes

Here is a patch to fix it.

Status: Needs review » Needs work

The last submitted patch, simplenews-footer_missing-1398208-1.patch, failed testing.

rooby’s picture

rooby commented
Status: Needs work » Needs review

I'd say the test failures for testSendHidden are due to something else, they would have been giving fale poositives before because the footer was not working at all.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Looks so, yes, but that just means the tests need to be fixed, so needs work.

Looking into it, rather dumb bug :)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new fix_footer_fix_and_add_tests.patch1.87 KB

Ok, this should fix the failures.

- Test failures were due to static caching problem's, it seems..
- Added additional test assertions to actually cover this bug.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Commited, thanks for reporting!

rooby’s picture

rooby commented

Excellent, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.