Some checkout panes (for example, the payment checkout pane) do not have a review callback. However, if you visit the checkout settings for such a checkout pane, the option "Include this pane on the Review checkout pane." is shown (and checked).

Patch attached hides this checkbox if a checkout pane does not have a review callback.

CommentFileSizeAuthor
#7 1397096-7.patch1.19 KBamateescu
#5 1397096-5.patch1.75 KBamateescu
hide-review-option-checkout-panes.patch1.29 KBmr.baileys

Comments

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Smart patch and a no-brainer. I think I noticed this when recording the Drupal Commerce for Beginners videos... silly for that checkbox to appear on the Review pane itself, for example. : P

Committed!

amateescu’s picture

amateescu commented
Status: Fixed » Reviewed & tested by the community

Cross-post :)

amateescu’s picture

amateescu commented
Status: Reviewed & tested by the community » Fixed

Restoring status.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

amateescu’s picture

amateescu commented
Status: Closed (fixed) » Needs review
StatusFileSize
new 1397096-5.patch1.75 KB

This commit introduced a notice that appears after saving a checkout pane that doesn't have a review callback.

Status: Needs review » Needs work

The last submitted patch, 1397096-5.patch, failed testing.

amateescu’s picture

amateescu commented
Status: Needs work » Needs review
StatusFileSize
new 1397096-7.patch1.19 KB

Ok then, let's go simple :)

nmc’s picture

nmc commented

This patch seems to be working for me. Thanks!

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Committed.

imiksu’s picture

imiksu
Location Finland
commented

As a reference for #5 comment, I post the notice error message:

Notice: Undefined index: review in commerce_checkout_pane_settings_form_save_submit() (line 286 of sites/all/modules/commerce/modules/checkout/includes/commerce_checkout.admin.inc).

This was noticed today also in #1443656: Notice: Undefined index: review in commerce_checkout_pane_settings_form_save_submit(), line 286.

The patch works for me :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.