Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I've seen mention elsewhere on drupal.org but don't see a feature request, so here goes.
The news aggregator is a great piece of Drupal as far as I'm concerned and I'd sure like to see it read all the sources out there, have the 'blog this' function, and also have a tool for browsers to generate a blog entry from a web page (like MT had).
Is that a big enough request? LOL
Thanks for all that everyone does here. Great stuff!
gil
Comment | File | Size | Author |
---|---|---|---|
#27 | aggregator-4.6.5-atom.patch | 4.14 KB | benwei |
#23 | AGGREGATOR_ATOM_CVS3.txt | 926 bytes | Prometheus6 |
#19 | AGGREGATOR_ATOM_CVS2.txt | 1.13 KB | Prometheus6 |
#16 | AGGREGATOR_ATOM_CVS_0.txt | 3.69 KB | Prometheus6 |
#14 | AGGREGATOR_ATOM_CVS.txt | 2.35 KB | Prometheus6 |
Comments
Comment #1
drummRSS 2.0 feeds should work in 4.5.0 and earlier.
Comment #2
georgehotelling CreditAttribution: georgehotelling commentedI've hacked Magpie support into the Drupal aggregator, so it can support Atom. If you have a Drupal site and want the code, you can get it from http://george.hotelling.net/projects/magpie-aggregator-4.5.2.tgz
I'm not sure if I'm supposed to create a patch or what, but I needed this for ArborBlogs.com and figured some other people would benefit from it.
Comment #3
Prometheus6 CreditAttribution: Prometheus6 commentedVery nice.
I hacked aggregator.module for 4.6 using your module as a guide...well, frankly by ripping out great chunks of code for my use.
Comment #4
Boris Mann CreditAttribution: Boris Mann commentedCan someone roll a patch for this? Would be a good addition for 4.7 now that Atom is at 1.0.
Comment #5
Prometheus6 CreditAttribution: Prometheus6 commentedA patch would require the Magpie include files and wholly restructures the way the feeds are parsed...the Magpie code would handle all the feeds, not just Atom.
That said, the attached zip file has the necessary includes and a patch to CVS.
Comment #6
Steven CreditAttribution: Steven commentedMagpie RSS duplicates a lot of functionality that is already in Drupal. We decided a long time ago that we would not use it. Porting Atom parsing into the current aggregator can't be that hard.
Comment #7
Prometheus6 CreditAttribution: Prometheus6 commentedSince I'm messing around with the aggregator module anyway...
I developed this around Atom 0.3 feeds this weekend, but I don't see anything in Atom 1.0 that should break it.
Comment #8
eaton CreditAttribution: eaton commented+1 on that patch. Running it now on my test site and everything looks great.
Comment #9
Bèr Kessels CreditAttribution: Bèr Kessels commenteda small issue, whe do not use
if ($data) $items[$item][$tag] .= $data;
please just use
Comment #10
Prometheus6 CreditAttribution: Prometheus6 commentedNot a problem. Here's the corrections.
Comment #11
Dries CreditAttribution: Dries commentedIf this is all it takes to parse Atom feeds (to some extend), I'm all for it. Code looks OK. Set to 'ready to be committed' after some testing.
Comment #12
kika CreditAttribution: kika commentedanybody up for a testing suite tests? http://intertwingly.net/wiki/pie/FormatTests
Comment #13
Prometheus6 CreditAttribution: Prometheus6 commentedThat would be for the Atom module.
Comment #14
Prometheus6 CreditAttribution: Prometheus6 commentedBecause the aggregator would always gather enough information todownload an Atom feed, the previous patch focused on parsing items/entries correctly.
This patch adds more complete parsing of the feed's channel data (site link, subtitle/description, logo). Now all the feed and item fields will be properly updated.
Comment #15
Prometheus6 CreditAttribution: Prometheus6 commentedThe content of the Atom feed's id and info tags were being displayed as part of the feed's description on the aggregator pages. With this patch those tags are recognized and discarded.
The "blog it" link is also added to the aggregator page items in addition to the block.
Comment #16
Prometheus6 CreditAttribution: Prometheus6 commentedLet's try that with the patch this time...
Comment #17
Dries CreditAttribution: Dries commentedCommitted a partial patch. Left out the 'blog it' stuff for now but committed the parsing part. The 'blog it' stuff needs more review and testing.
Comment #18
Prometheus6 CreditAttribution: Prometheus6 commentedOkay. Just to let you know, I added the blog it link because of this conversation.
http://drupal.org/node/10752
I'll make a patch tonight just for the blog it feature, so this item can be closed if you like.
Comment #19
Prometheus6 CreditAttribution: Prometheus6 commentedAtom feeds have a CONTENT and/or SUMMARY tag instead of a DESCRIPTION tag. Currently, if both tags are present the aggregator appends the content of both fields to replace the content of the DESCRIPTION tag. This patch uses the CONTENT tag OR the SUMMARY tag.
Comment #20
Dries CreditAttribution: Dries commentedComment #21
robertDouglass CreditAttribution: robertDouglass commentedI'm confused; is this applied to HEAD, or not? My latest installation of HEAD does not handle Atom feeds, so if it is in there, it is broken.
Comment #22
Prometheus6 CreditAttribution: Prometheus6 commentedThe title isn't being picked up so the items aren't being saved....I'll look at it today.
Comment #23
Prometheus6 CreditAttribution: Prometheus6 commentedHere's a correction. I'll explain it if I have to...I'm a little sleepy at the moment.
Comment #24
Dries CreditAttribution: Dries commentedCommitted to HEAD. Thanks.
Comment #25
(not verified) CreditAttribution: commentedComment #26
Prometheus6 CreditAttribution: Prometheus6 commentedComment #27
benwei CreditAttribution: benwei commentedHey,
I know this issue is closed, but just as a convenience for people still on 4.6 who want to get at the feature, I've applied all three of these patches to a default 4.6.5 install and made a single, combined patch that works against 4.6.5 out of it.
Cheers,
Ben Weintraub