I noticed that the products report was not showing the first adjustment's SKU even if the product count was right.
It seems the way the array are merged in _uc_reports_product_get_skus() will discard the first adjustment SKU.

Files: 
CommentFileSizeAuthor
#3 uc_reports.admin_.inc_products_report_sku.patch1015 bytesquadbyte
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch uc_reports.admin_.inc_products_report_sku.patch. Unable to apply patch. See the log in the details link for more information. View
#1 _uc_reports_product_get_skus_1393000.patch1019 bytesquadbyte
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch _uc_reports_product_get_skus_1393000.patch. See the log in the details link for more information. View

Comments

quadbyte’s picture

FileSize
1019 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch _uc_reports_product_get_skus_1393000.patch. See the log in the details link for more information. View

Status: Needs review » Needs work

The last submitted patch, _uc_reports_product_get_skus_1393000.patch, failed testing.

quadbyte’s picture

Status: Needs work » Needs review
FileSize
1015 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch uc_reports.admin_.inc_products_report_sku.patch. Unable to apply patch. See the log in the details link for more information. View

Re-rolled the patch toward latest dev version.

Status: Needs review » Needs work

The last submitted patch, uc_reports.admin_.inc_products_report_sku.patch, failed testing.

longwave’s picture

Status: Needs work » Fixed

Confirmed and committed, thanks for the patch, apologies for taking so long to get around to reviewing it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.