Hoo Boy,

I really appreciate all the work done on the Alpha 2 release but some serious bugs have crept in. The statistics module no longer works. I checked the email source and the code that stats inserts is no longer there. I tried uninstalling stats and reinstalling it and sending a new newsletter but no stats.

Please help guys....

Comments

berdir’s picture

I am not sure what statistics module you're talking about.

There is http://drupal.org/project/simplenews_statistics but this never was part of this project.

There have been API changes in alpha1 -> alpha2 (It's alpha after all) so if you're using the above module then it probably needs to be updated.

berdir’s picture

Had a quick look at the above module and it's kinda obvious that it doesn' work anymore. The process of sending mails has been completely re-worked and needs to be updated.

The main problem is this and the related lines of code:

if ($message['module'] == 'simplenews' && $message['params']['context']['category']->format =='html') 

Instead of the different context things like account, node and category, there is now only the source object passed through.

See http://api.worldempire.ch/api/simplenews/includes--simplenews.mail.inc/f... and http://api.worldempire.ch/api/simplenews/simplenews.module/function/simp.... (And yes, documentation needs to be updated there)

If you are using the mentioned module, then please move the issue over to that project.

r0bm1lls’s picture

OK - thanks for the feedback. I have posted an issue with simplenews_statistics module.

Thanks

berdir’s picture

Title: Stats module no longer working » Add change notice and update simplenews_mail() documentation
Version: 7.x-1.0-alpha2 » 7.x-1.x-dev
Category: bug » task
Priority: Major » Normal

Ok, thanks.

When you do something like this, please always reference newly created issues in both ways by adding "[#issue]", this will then automatically be converted into a link: #1390184: Port current D6 release to D7.

Changing this issue to a task to improve our documentation about that change.

berdir’s picture

Status: Active » Needs review
StatusFileSize
new1.92 KB

The attached patch updates the mentioned documentation issues

berdir’s picture

StatusFileSize
new3.58 KB

Change notice at http://drupal.org/node/1390222.

Updated patch also contains the missing hook documentation and a fixed class reference.

berdir’s picture

Status: Needs review » Fixed

Ok, commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.