Closed (fixed)
Project:
HTML5 Tools
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
30 Dec 2011 at 06:44 UTC
Updated:
30 Mar 2012 at 07:20 UTC
The HTML5 shiv has been updated to v3 and the InnerShiv script is dead. From http://jdbartlett.com/innershiv/:
STOP! Don't use innerShiv!
html5shiv now patches for the innerHTML issue! Update html5shiv and you won't have to use innerShiv anymore:
That still leaves the monkey patch. In its current form, it doesn't work since it uses a function that isn't in the v3 of the HTML5 shiv.
Also, the monkeypatch is not needed for jQuery 1.7, but the jQuery Update module doesn't use 1.7 yet: #1386294: Release jQuery 1.7 for Drupal 7. Do we require the jQuery Update module once its updated? Or do we not? And what do we do in the interim?
Comments
Comment #1
danny_joris commentedComment #2
ericduran commentedHmm, I haven't looked into this yet.
But it seems instead of doing innerShiv(response.data) we can do html5.shivDocument(response.data) until the jquery_update project updates to 1.7. Then after that we can just required 1.7 in order to properly support html5 elements.
Comment #3
ericduran commentedYea, I just updated to the latest html5shiv and added a jquery_update dependency.
People should really be using jquery 1.7 :)
Comment #5
mossy2100It would be useful to newcomers to this project to remove the reference to innershiv from the project page.