I am working on a module that uses hook_js_alter() to replace the core JS with minified alternatives (of the correct version).

Minifying overlay-parent.js, however, breaks it due to the lack of a semi-colon at the end of the Drupal.overlay.setFocusBefore and Drupal.overlay._recordTabindex functions.

Attached is a patch to add the required semi-colons and allow the file to be successfully minified.

CommentFileSizeAuthor
#3 1387002.patch714 bytesrobloach
overlayparentjs_allow_minification.patch694 bytesnburles

Comments

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

:) thnx

catch’s picture

catch
he/him
Primary language English
commented
Version: 7.x-dev » 8.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)
Issue tags: +Needs backport to D7

Needs fixing in 8.x first.

robloach’s picture

robloach
he/him
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1387002.patch714 bytes
aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

RTBC again

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x and 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.