I was looking to add hook_hook_info() integration for Coder hooks and realized that coder_review is calling module_invoke_all('reviews') which means this hook will conflict with a theoretical 'reviews' module. The hook should actually be coder_review_reviews.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 1376266-coder-review-hook-namespace.patch | 11.94 KB | dave reid |
Comments
Comment #1
dave reidThis postpones:
#1376294: Add support for coder hooks in modulename.coder.inc via hook_hook_info
#1376290: Missing way to alter the coder reviews and rules (hook_coder_reviews_alter)
Comment #2
dave reidComment #3
dave reidPatch attached that converts hook_reviews() to hook_coder_review_info() (since we'd already need to rename this hook, let's name it as a 'proper' hook) ands add caching to the review info hook results.
Comment #4
dave reidThis probably needs to add something like module_load_all_includes('coder.inc') since all the review callbacks would be located inside the modulename.coder.inc files as well.
Comment #5
klausiCoder 7.x-1.x is frozen now and will not receive any updates. Coder 8.x-2.x can be used to check code for any Drupal version, Coder 8.x-2.x also supports the phpcbf command to automatically fix conding standard errors. Please check if this issue is still relevant and reopen against that version if necessary.