I think the following two functions in commerce_payment.module are misnamed:

  • commerce_order_commerce_payment_transaction_update()
  • commerce_order_commerce_payment_transaction_insert()

This is because these are hooks within commerce_payment, not commerce_order. They should actually be called:

  • commerce_payment_commerce_payment_transaction_update()
  • commerce_payment_commerce_payment_transaction_insert()

Comments

rszrama’s picture

rszrama commented

Hmm, funny. It doesn't appear that renaming them would have any consequences. I guess they started out in the Order module and got moved over but not renamed. : P

rszrama’s picture

rszrama commented
Status: Active » Fixed

Tested and confirmed all works fine. Thanks for digging this up!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.