Closed (fixed)
Project:
CacheExclude
Version:
7.x-2.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Dec 2011 at 07:12 UTC
Updated:
25 Jan 2013 at 21:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
Crell commentedComment #2
andypostI think this hunk is useless at all. because path gets initialized before hook_init() see _drupal_bootstrap_full()
I see no reasonable case for this code to be called and it's wrong because drupal_path_initialize() uses
if (empty($_GET['q'])) {Also there's a extra white-space in patch.
Comment #3
andypostBootstrap is changed in D7 so there's no DRUPAL_BOOTSTRAP_PATH phase so this hunk should be removed with comment for hook_init() implementation.
see drupal_bootstrap() D7 & _drupal_bootstrap() D6
Comment #4
rickmanelius commentedAnd drupal_path_initialize() is called in _drupal_bootstrap_full
http://api.drupal.org/api/drupal/includes%21common.inc/function/_drupal_...
I tested patch #3 against a custom URL pattern and it works as expected. Marking as RBTC.
Comment #5
Crell commentedIrony: I just finally got around to tagging a release for Drupal 6 that *adds* that check. Nice to know we can remove it in D7. :-)
Committed and pushed #3. Thanks!
Comment #6.0
(not verified) commentedJust a typo.