Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Dec 2011 at 00:32 UTC
Updated:
16 Feb 2012 at 04:16 UTC
Jump to comment: Most recent file
Comments
Comment #1
jhodgdonSo are you saying that this is to be used for batch pages that are non-JS, or that it is used for non-batch pages?
Comment #2
patrickd commentedComment #3
patrickd commentedSorry you posted, while I did^^
Comment #4
patrickd commentedaww...
Comment #5
patrickd commentedOMG, commented the wrong function... -.- clearly too late!
This is the right one:
Comment #7
aspilicious commentedNeeds a newline between those lines.
18 days to next Drupal core point release.
Comment #8
patrickd commentedyou mean
?
Comment #9
aspilicious commentedYes see http://drupal.org/node/1354#functions for more info.
Comment #10
patrickd commentedSorry! This one hopefully..
Comment #11
jhodgdonI still have a question on this. Is there a reason why someone couldn't use this function to make a progress bar for other things besides batch jobs? And why can't this be used for batch jobs running under JS?
Comment #12
patrickd commentedFor shure, anyone can use this function to make his own progress bars.
Note that this is only used for non-javascript batch jobs.
batch.inc:
in function
_batch_progress_page_js()returned markup is hardcoded and simply
<div id="progress"></div>the progressbar markup will later by added by javascript without using
theme_progress_barin function
_batch_progress_page_nojs()it uses
return theme('progress_bar', array('percent' => $percentage, 'message' => $message));Is there something you would change on the sentence?
Comment #13
jhodgdonOK. The wording that is in the patch now is:
Note that this is only used for non-javascript batch jobs.
That can be read as "You can only use this for batch jobs that are not JavaScript."
I think it needs to be reworded so that it means "You can use this for non-JavaScript batch jobs, or for things other than batch jobs", hopefully more succinctly.
Also, javascript should be capitalized properly as "JavaScript".
Comment #14
patrickd commentedHmm lets say somone uses this theme function, I think he won't implement a new batch system..
The thing I really want to point out is that..
That anyone can use this for his own stuff like a in-page progress bar (without using the batch API) should be clear anyway
you understand what I mean?^^
Comment #15
jhodgdonThat sounds like a good way to word the line you want to add. :)
Comment #16
patrickd commentedOkay, I hope this one is clear:
Comment #17
jhodgdonThat seems fine to me. I think having this in the docs is worthwhile, since themers will then be aware, if they override this function, what it will affect.
Comment #18
catchThis makes me wonder if we really need a dedicated hook_theme() for non-js progress bars at all, but good for the docs to be honest about how limited it is anyway.
Committed/pushed to 8.x, moving back to 7.x.
Comment #19
patrickd commentedYep, is there already a new implementation of the Batch API planned yet?
attached rerolled patch against d7
Comment #20
jhodgdonLooks fine for d7, thanks!
Comment #21
webchickCommitted and pushed to 7.x. Thanks!