Add support to display patches applied to release packages [#1365446]

Splitting this off from #779998: Add support to record patches applied to release packages so we can discuss the UI separately from all the backend plumbing for how to find out and store the data about what patches are applied to a given packaged release.

Basically, we need to modify the tables of stuff included in a release (e.g. on pages like http://drupal.org/node/1006918) so that if either a project or an external library has patches applied, the table says so.

Some possible thoughts:

A) Enhance the "version" column to indicate if a thing has been patched and give you somewhere to click for more details.

B) Condense the "status" column (e.g. put the recommended/current version in a tooltip or something) and add another column about patches.

Comment	File	Size	Author
#12	project-alpha5-docs.patch	301 bytes	dww
#7	1365446-7.distro-patches-ui.png	130.24 KB	dww
#5	Copy_of_Home.jpg	35.76 KB	Bojhan
#4	wireframe-initial-idea.jpg	66.28 KB	Bojhan
#1	Picture 7.png	26.57 KB	yoroy

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

yoroy CreditAttribution: yoroy commented 8 December 2011 at 22:45

File	Size
Picture 7.png	26.57 KB

Firebug sketch:
1, 2"

Comment #2

dww

we/he/they

CreditAttribution: dww commented 8 December 2011 at 22:48

Yup, that's a great start.

However, I'm not sure 1 is all we need. Even though we might be able to link to an issue/comment where a patch file lives, it seems important to at least somehow display the actual URL of the patch file. A given issue comment might have 10 patches attached to it, so we need to know exactly *which* patch it is.

Thanks for spending time pondering this issue!

Cheers,
-Derek

Comment #3

yoroy CreditAttribution: yoroy commented 8 December 2011 at 22:54

Bojhan: yhea, I would do something like "4 custom patches applied (details)". More scalable, than linking each patch

yoroy_: possibly, but then that 'details' link would have to summarize/link to each patch individually so, that page would have to be generated then

Bojhan: yes

yoroy_: cool. probably best to offload that info to somewhere else.

Comment #4

Bojhan CreditAttribution: Bojhan commented 9 December 2011 at 23:34

File	Size
wireframe-initial-idea.jpg	66.28 KB

Wireframe alternative showing 3 tables.

Comment #5

Bojhan CreditAttribution: Bojhan commented 9 December 2011 at 23:43

File	Size
Copy_of_Home.jpg	35.76 KB

Or everything in one table.

Comment #6

dww

we/he/they

CreditAttribution: dww commented 9 December 2011 at 23:57

Issue tags:

-Usability

I like where #4 is headed. That should be relatively easy to implement. The externals and patches tables will obviously only appear if there are any externals or patches to display. ;)

I don't like #5 for a few reasons:
- Seems impossible to cram enough info about patches into that design to make it useful
- It'll be harder to implement for backend reasons (each of these tables is a view of different kinds of stuff, so it's messy to merge them).

We could of course move to custom code to build these, but I'd rather use views whenever possible for stuff like this.

Given how few people look at these pages, I lean towards the slightly more verbose #4 since it's easier to build and will provide more useful info to the people who care (even if it's not quite as beautiful as it might otherwise be).

Removing the "Usability" tag for now. Once this is closer to reality, I might post real screenies and tag it "Needs usability review" for one last quick sign-off, but I think we're in good shape here...

Thanks!
-Derek

Comment #7

dww

we/he/they

CreditAttribution: dww commented 13 January 2012 at 06:51

Assigned:	Unassigned	» dww
Status:	Active	» Needs review

File	Size
1365446-7.distro-patches-ui.png	130.24 KB

I've made a bunch of progress on this and wanted to post a screenie of a completely hacked dummy test node from my laptop. But, at least it's showing off most of the functionality described here. Everything here is being generated by views. All the code lives on the 779440-distro-packaging branch of project.

The one case I haven't yet done is patches applied to remote items (aka "libraries"). That's a bit more of a pain in the ass, and I don't think it's critical for initial deployment. So, I wanted to get what I've got working up here for review. Meanwhile, if I'm feeling inspired, I'll take a crack at this final edge case...

Comment #8

dww

we/he/they

CreditAttribution: dww commented 13 January 2012 at 08:12

Woo hoo. Here it is working on a live d.o dev site:

http://distro-drupal.redesign.devdrupal.org/node/1402264

Yee haw,
-Derek

Comment #9

dww

we/he/they

CreditAttribution: dww commented 13 January 2012 at 08:26

Here's a slightly more sane example:

http://distro-drupal.redesign.devdrupal.org/node/1402268

This is mostly up-to-date code, but it's also got 3 patches applied (including 2 to the same project).

Comment #10

Bojhan CreditAttribution: Bojhan commented 14 January 2012 at 01:07

I gave it a quick review, there are some parts we can improve:

1) More spacing around the tables for scanning,
2) Shorter patch links

However we concluded, that the most important things are there and there are no confusing parts - the suggestions would merely be tweaking. Dww can spend valuable time on solving a lot of other issues, so I suggest we put it in as currently shown.