Unit testing seems like it would be pretty useful.

We should at least be testing for basic behavior compliance.

Comments

geerlingguy’s picture

geerlingguy commented
Version: 6.x-1.0-beta1 » 7.x-1.x-dev
Assigned: gboudrias » geerlingguy

I'm going to add some tests to the 7.x branch; once finished, if you'd like to port them back to 6.x, that might be a simpler operation than trying to recreate the tests altogether.

geerlingguy’s picture

geerlingguy commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Assigned: geerlingguy » Unassigned
Status: Active » Patch (to be ported)

See commit for 7.x here: http://drupalcode.org/project/user_limit.git/commit/f14123e

Bumping back to 6.x for porting.

lars toomre’s picture

lars toomre commented

I was just looking at the tests that were added in #2. Be aware that D8 and D7 are moving toward removing t() from all test assert messages and group parameters. You might want to do the same going forward.

geerlingguy’s picture

geerlingguy commented

Ah, sounds like a good plan. I've noticed a ton of commits lately mentioning t(), but haven't read into them much. I'll remove them next time I run through them.

[Updated: committed fix removing t() from assertion messages - http://drupalcode.org/project/user_limit.git/commit/cb7223e]