1. Why do we use version 2.69 of the google api, and not the latest we would get by just requesting v=2 (currently 2.76) ?
  2. Wouldn't it be more efficient (bandwidth-saving) to send the points as arrays instead of objects with properties 'latitude' and 'longitude' to the client ?
  3. Currently gmap_draw_map() does nothing. Is there a reason to not make it a thin wrapper just doing
    return theme('gmap', array('#settings' => $map)); ?

Just wondering ;-)

Comments

ray007’s picture

ray007 commented

No answers?
Are the questions that stupid?

bdragon’s picture

bdragon commented

1) Because that's how 4.7 did it, and I didn't bother to change it. Next time I add a feature that needs a newer version, I'll go ahead and take that out and change it to request v2.
2) Yeah, and it might happen that way in the future. I already compress the crap out of the icon definitions before sending them.
3) It historically accepted raw javascript. This is not compatible with the 5.x way of doing things, which is why I am removing it completely. Any function that called it needs to be rewritten anyway, so there's no point in wrapping it.
4) They aren't stupid, but I missed the report the first time through. I recently subscribed myself to the entire queue, so this shouldn't happen in the future.

bdragon’s picture

bdragon commented
Status: Active » Closed (works as designed)

1) We now use v=2.
2) This still needs work, but should have its own master issue.
3) I killed gmap_draw_map completely now.

(Marking as by design because I really need to get this queue cleaned up a bit.)