There's no default value set, so we should pass an empty array, no?

CommentFileSizeAuthor
#1 moved_deltas_param-1363244-1.patch362 bytesezeedub

Comments

ezeedub’s picture

Status: Active » Needs review
StatusFileSize
new362 bytes

Here's a patch.

iamEAP’s picture

Status: Needs review » Reviewed & tested by the community

This fixed a huge stack of warnings I got when upgrading to 7.

Trivial enough that I'm marking it as RTBC. Please commit!

damienmckenna’s picture

Per the API docs for update_fix_d7_block_deltas() the patch will fix the problem. +1

stevecowie’s picture

Status: Reviewed & tested by the community » Closed (fixed)

This has been committed to dev

jamesoakley’s picture

I've read the note on the project homepage about the level of maintenance for the module. All fair enough.

Notwithstanding, is there any chance we could have a 7.x-1.4 release for the module so that this gets picked up? I've just upgraded a site from D6 to D7, and found that logintoboggan_update_7000 failed. I realise that I can download the -dev release or apply the patch in this issue, but others will make the same assumption that I did, namely that a full release against Drupal 7 is the one to use if upgrading a site. 7.x-1.3 was released last November, so I'm guessing there must be other bugs that have been fixed that a new release could hoover up.

Any chance?

stevecowie’s picture

James
A new point release is long overdue so I will aim to commit some serious maintenance time to this during October and get a release out by the end of the month.

jcisio’s picture

Hi,

I see that the issue queue is quite active and you've committed lots of time recently. Do you plan a stable release soon, you will wait for more serious bugs to be fixed?

stevecowie’s picture

Yes, I missed that October deadline I set myself :-( but we've been busy going through the queue in detail and identifying what needs to be done ahead of a release. As we have a fairly comprehensive overhaul of the user interface in mind, it might be sense to do an interim stable release hoovering up smaller bugs, and then do another one maybe late January with the ux changes.

damienmckenna’s picture

@stevecowie: +1 for that idea.

jcisio’s picture

I think the dev snapshot is actually not based on the 7.x-1.x branch, but on master. So commits like this one are not in the dev snapshot :( I think when there is not stable release yet, could we make 7.x-1.x-dev based on 7.x-1.x branch?

I searched a bit but could not see any issue about branching problem with the snapshot. So I add it into this issue.

stevecowie’s picture

You're right, and I don't quite understand why so I'm looking into this urgently

stevecowie’s picture

Assigned: Unassigned » stevecowie
Status: Closed (fixed) » Fixed

Have figured it out. For some reason when I took over maintenance on the module there was no 7.x-1.x branch so I created one. However, I guess that because that branch didn't exist, the dev snapshotting system used master instead, but isn't configured to automatically switch over. I edited the dev release page to get dev tracking 7.x-1.x and will download this tomorrow to ensure the correct branch is now associated with dev.

None of this , btw, removes the need to create a new release asap so I'll make an absolute commitment to do that before the end of February.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.