The type parameter is supposed to act as a filter but all line items are added regardless of the value.

CommentFileSizeAuthor
#1 commerce_line_items_total_ignores_type_param-1362774.patch763 bytesiswilson

Comments

iswilson’s picture

iswilson commented
Status: Active » Needs review
StatusFileSize
new commerce_line_items_total_ignores_type_param-1362774.patch763 bytes

Patch attached:

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Well crap. : P

I swear we've fixed this twice, but it keeps coming up. Either we rolled back a change or we just fixed it in Quantity last time. Thanks for catching this! Committed.

Shipping 2.x working fine for you w/ Canada Post?

iswilson’s picture

iswilson commented

Shipping 2.x works great so far thanks. The Canada Post module I made for it is in a pretty solid state and I put it up for code review.

rszrama’s picture

rszrama commented

Awesome, glad to hear it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.