Support for contextual links

Sorry, I should have explained the problem in more detail. What I've done is to inject a contextual links menu for primary links (= main menu) and that won't be displayed properly without the modifications in the css file.

There are two negative effects that I can explain and that are visible in the attachments to this post:

1) The widget on the right is not displayed properly, see "aperture original.jpg" and "aperture modified.jpg"

2) The dropdown from the widget widget on the right is not displayed properly, see "aperture original dropdown.jpg" and "aperture modified dropdown.jpg"

Please let me know if you need more details.

Yes, there is a simple hook in Drupal core that allows to attach contextual link menus to any kind of object on a page and the primary menu in particular is something that desperatly needs contextual links.

The proposed changes in the CSS are - even without the contactual link requirement - just a bit more specific to the elements in your great template. So there shouldn't be any harm in adding them into the theme.

I guess you're right, #main-menu is just as good.

In which way, can you illustrate the effect?

Why should it not apply anymore? THe only ul that is available in #navigation does have the links class, so the selector "#navigation ul.links" should be perfectly right. Can't see what's wrong with it.

No worries, CSS can be confusing some times. I have attached the shortened patch which is working fine here, unless I've overlooked something. Please let me know.

However, while looking at the code I was thinking that we could make the definitions for the a elements within #navigation and #main-menu still a bit more specific so that really only those get affected that should be.

You're right, sorry I missed that. I've just checked the situation and found out that this is why we had ul#main-menu in the first patch. So I revert back to that first patch.

No problem, here you go:

/**
 * Implements hook_theme();
 */
function MYMODULE_theme($existing, $type, $theme, $path) {
  $items['links__system_main_menu'] = array(
    'variables' => array('menu' => 'main-menu', 'links' => NULL, 'attributes' => array('class' => array('links')), 'heading' => array()),
    'function' => 'MYMODULE_theme_menu',
  );
  $items['links__system_secondary_menu'] = array(
    'variables' => array('menu' => 'secondary-menu', 'links' => NULL, 'attributes' => array('class' => array('links')), 'heading' => array()),
    'function' => 'MYMODULE_theme_menu',
  );
  $items['menu_tree__main_menu'] = array(
    'render element' => 'tree',
    'function' => 'MYMODULE_theme_menu',
  );
  $items['menu_tree__secondary_menu'] = array(
    'render element' => 'tree',
    'function' => 'MYMODULE_theme_menu',
  );

  return $items;
}

function MYMODULE_theme_menu($variables) {
  if (isset($variables['tree'])) {
    $tree = $variables['tree'];
    foreach ($tree['#theme_wrappers'] as $theme_wrapper) {
      if (strpos($theme_wrapper, 'menu_tree__') !== FALSE) {
        $menu = str_replace('_', '-', substr($theme_wrapper, 11));
        $links = theme('menu_tree', $variables);
        break;
      }
    }
  }
  else {
    $menu = $variables['menu'];
    unset($variables['menu']);
    $links = theme('links', $variables);
  }
  if (empty($links)) {
    return '';
  }
  $build = array(
    'links' => array('#markup' => $links),
  );
  if (user_access('access contextual links')) {
    $build += array(
      'contextual_links' => array(
        '#type' => 'contextual_links',
        '#contextual_links' => array('menu' => array('admin/structure/menu/manage', array($menu)))
      ),
      '#prefix' => '<div class="contextual-links-region">',
      '#suffix' => '</div>',
    );
  }
  return drupal_render($build);
}