When working with the last dev I got Fatal error: Class 'TaxonomyTermController' not found, which seems to depend on a dependencie in the newly added code in the repo.

CommentFileSizeAuthor
#9 check_for_class-1361912-9.patch2.71 KBlangworthy
#6 check_for_class-1361912-4.patch2.66 KBmisc
#3 check_for_class-1361912-2.patch3.18 KBmisc
#1 taxonomy_and_field_as_dependencies_1361912_1.patch473 bytesmisc

Comments

misc’s picture

misc commented
Status: Active » Needs review
StatusFileSize
new taxonomy_and_field_as_dependencies_1361912_1.patch473 bytes

Attached patch, also included field as an dependencies, because of that I think it should be enabled to use the field storage module.

Status: Needs review » Needs work

The last submitted patch, taxonomy_and_field_as_dependencies_1361912_1.patch, failed testing.

misc’s picture

misc commented
Status: Needs work » Needs review
StatusFileSize
new check_for_class-1361912-2.patch3.18 KB

New patch, I think this is a better one, that checks if the class exists instead, also check the others classes.

Status: Needs review » Needs work

The last submitted patch, check_for_class-1361912-2.patch, failed testing.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented

Can you really think of a situation where the DrupalDefaultEntityController will not be available ? It is defined in the core includes, not in a module, so should always be present.

misc’s picture

misc commented
StatusFileSize
new check_for_class-1361912-4.patch2.66 KB

You are right, that one we should not need to check . New patch attached.

misc’s picture

misc commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, check_for_class-1361912-4.patch, failed testing.

langworthy’s picture

langworthy commented
Status: Needs work » Needs review
StatusFileSize
new check_for_class-1361912-9.patch2.71 KB

I wasn't able to apply the patch in #6.

I think this will work.

Status: Needs review » Needs work

The last submitted patch, check_for_class-1361912-9.patch, failed testing.

misc’s picture

misc commented
Status: Needs work » Patch (to be ported)
fgm’s picture

fgm
Primary language French
Location Paris, France
commented

MiSc: where do you want to port this patch ? There is no entity system in D6 and module does not yet have a D8 branch.

misc’s picture

misc commented
Status: Patch (to be ported) » Closed (fixed)

Sorry wrong state. By accident I used that state for all patches that I was applying to the latest dev when trying them out, it shuld have been RTBC for all...

Patch was applied to 7.x-1.x

misc’s picture

misc commented
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.