Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The actions need to be completely overhauled.
If this is too much work, we'll drop action support for initial stable release.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | thou_shall_be_gone_forever.patch | 13.29 KB | berdir |
| #3 | thou_shall_be_gone.patch | 12.47 KB | berdir |
Comments
Comment #1
miro_dietikerRelated issues
#620498: Integration with Rules module
Comment #2
berdirRelated issues:
- #1125532: Error creating an action with Simplenews action module
- #1069212: Actions not deleted on newsletter/newsletter issue delete
Comment #3
berdirPretty much all actions seem to be broken currently, trigger invocations are certainly broken. Also, there seem to be close to zero contrib projects which still support triggers/actions. Instead, most provide support with Rules, which should be our goal as well.
The attached patch removes the simplenews_actions module.
Comment #4
berdirComment #6
berdirForgot two calls to the removed function, this one should be better.
Comment #7
berdirThe new rules integration is coming along nicely. See #620498: Integration with Rules module.
Committed the patch and removed the existing, broken actions integration.
Comment #9
amonteroUndoubtedly, Rules integration is more versatile, but 'action' module seems to be available on 8.x, altough as an optional module:
#1008166: Actions should be a module
I still see core style actions a valid use case. For example, an admin view with VBO, not requiring any rules code. Why kill core actions?
The attached patch adds a 'Set user subscriptions' action. It reuses user profile form to present the selection screen. Works well for me and avoids me having to install another module just to do that.
Warning: The selected subscriptions will replace current ones.
Of course, basic Rules module actions can be wrappers around this actions with extended properties. Or the other way around. What do you think?
Comment #10
amonteroUnassigning and letting the testbot run through it.