In the name of contrib independence, this must be rolled back.

CommentFileSizeAuthor
#6 1361136_rollback_ctools_6.patch4.11 KBnaught101

Comments

naught101’s picture

Ok. I know we're using it for relation type import/export, so we can just leave that stuff in with a module_exists call, right? Or split it off into a relation_type_export submodule or something.

What other stuff do we use it for?

chx’s picture

Multiple load depends on it, that's what's needed to be rolled back. Just search for ctools.

chx’s picture

matglas86’s picture

I agree with chx. Currently the beta is running against a dev version of CTools which makes it the more unstable. If I knew how to do a rollback patch I would do that but don't know really how to start on that. Any tutorial hint on doing that? Can I do something like that with bisect?

naught101’s picture

you could try reverse-applying that commitdiff (the patch is http://drupalcode.org/project/relation.git/patch/b80c9a3?hp=5503c9193691...)

It probably won't work, so you're likely just going to have to manually go through the patch, and work out what changes need to be made where. There might be a couple of other places that also need changing, that would basically require searching through the whole module for any instances of ctools_* that aren't inside an if (module_exists('ctools')) { ... } statement, and putting them inside one.

naught101’s picture

Component: Code » API
Status: Active » Needs review
StatusFileSize
new4.11 KB
jthorson’s picture

Confirmed 100% of branch tests pass after #6 (manual test on scratchtestbot).

chx’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.