Closed (fixed)
Project:
Relation
Version:
7.x-1.x-dev
Component:
API
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Dec 2011 at 07:16 UTC
Updated:
11 Mar 2012 at 21:10 UTC
Jump to comment: Most recent file
In the name of contrib independence, this must be rolled back.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 1361136_rollback_ctools_6.patch | 4.11 KB | naught101 |
Comments
Comment #1
naught101 commentedOk. I know we're using it for relation type import/export, so we can just leave that stuff in with a module_exists call, right? Or split it off into a relation_type_export submodule or something.
What other stuff do we use it for?
Comment #2
chx commentedMultiple load depends on it, that's what's needed to be rolled back. Just search for ctools.
Comment #3
chx commentedhttp://drupalcode.org/project/relation.git/commitdiff/b80c9a3?hp=5503c91... this needs to be reverted.
Comment #4
matglas86 commentedI agree with chx. Currently the beta is running against a dev version of CTools which makes it the more unstable. If I knew how to do a rollback patch I would do that but don't know really how to start on that. Any tutorial hint on doing that? Can I do something like that with bisect?
Comment #5
naught101 commentedyou could try reverse-applying that commitdiff (the patch is http://drupalcode.org/project/relation.git/patch/b80c9a3?hp=5503c9193691...)
It probably won't work, so you're likely just going to have to manually go through the patch, and work out what changes need to be made where. There might be a couple of other places that also need changing, that would basically require searching through the whole module for any instances of ctools_* that aren't inside an
if (module_exists('ctools')) { ... }statement, and putting them inside one.Comment #6
naught101 commentedComment #7
jthorson commentedConfirmed 100% of branch tests pass after #6 (manual test on scratchtestbot).
Comment #8
chx commented