AdvAgg (6.x-1.6 and 6.x-1.x-dev) is working great for me except with on popups, created via Popups API (6.x-2.0-beta0,) where all CSS and JS files are being included individually instead of aggregated.
If you enable the "Popups: Test Page" submodule of popups, browse to admin/settings/popups
, and click the here link, it will show a test popup that exhibits this. I used the Firefox Tamper Data plugin to see that those CSS/JS files are being transferred individually.
In my case, this is screwing up the layout of the rest of the page (behind the popup) when the popup is launched, as the new, un-aggregated CSS loaded is somehow cascading differently.
Comment | File | Size | Author |
---|---|---|---|
#9 | popups-1358506-9.patch | 945 bytes | herved |
#2 | popups-1358506-2.patch | 848 bytes | mikeytown2 |
Comments
Comment #1
jeffschulerStill digging...
Popups, in the stylesheets that it's [perhaps unnecessarily] re-including, is leaving out a few key ones, like:
sites/all/themes/fusion/fusion_core/css/grid12-960.css
sites/all/themes/my_fusion_subtheme/css/local.css
So, styles from the sheets it does load override declarations of same specificity from these missing sheets, (whose styles were loaded earlier.)
Popups has some smarts in trying to load only stylesheets that are not already loaded. However, since it doesn't seem to know everything that advagg has already supplied, aggregated, and then loads those all again, yet it DOES see that grid12-960.css is there, (since Fusion loads it somewhat dynamically and advagg doesn't know about it,) that one gets left out and is overridden.
Comment #2
mikeytown2 CreditAttribution: mikeytown2 commentedIn popups_preprocess_page() it detects if core's aggregration is turned off; it does not take into account AdvAgg. This patch should fix the issue.
Comment #3
jeffschulerThis fixed the issue. Thanks mikeytown2!
We'd appreciate seeing this incorporated into Popups.
Comment #4
dharani87 CreditAttribution: dharani87 commentedFor me the same problem causes,while my core css aggregation is turned on.
Is there any solution for that?
Thanks
Dharani
Comment #5
jeffschuler@dharani87: this is specific to the http://drupal.org/project/advagg module's interaction with Popups. I'd look for another issue relating to core CSS aggregation or open a new one.
Comment #6
dharani87 CreditAttribution: dharani87 commented@jeffschuler Sorry to post here!!( i thought the patch is related to my issue)
Better i will look some other place for the solution
Thanks
Dharani
Comment #7
pvanerk CreditAttribution: pvanerk commentedPatch works for me, would be nice to have this in the next stable version.
Comment #8
szy CreditAttribution: szy commentedMy fault, sorry. Please delete it.
Comment #9
herved CreditAttribution: herved commentedThank you all,
Here's an other version of #2 making sure advagg exists and variables (advagg_preprocess_css and advagg_preprocess_js) are set to TRUE.
And yea... I'm still working on a D6 website...
Regards,
Hervé
Comment #10
jeffschuler