hook_requirements initializes its return array as $requirements = array('varnish');.

This adds 0 => 'varnish' instead iof the desired 'varnish' => array(),

I noticed this using tha nagios module which invokes hook_requirements

The attached patch fixes this.

CommentFileSizeAuthor
#5 0001-Issue-1358276-fixed-incorrect-return-from-varnish_re.patch824 bytesfgm
varnish-hook_requirements_zero_key.patch481 byteshelmo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

helmo’s picture

helmo CreditAttribution: helmo commented
Component: Documentation » Code
fabsor’s picture

fabsor CreditAttribution: fabsor commented
Status: Needs review » Fixed

Commited. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Issue summary: View changes
Status: Closed (fixed) » Patch (to be ported)

This needs to be ported to D6 where the problem also exists.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Status: Patch (to be ported) » Needs review
FileSize
0001-Issue-1358276-fixed-incorrect-return-from-varnish_re.patch824 bytes

Suggested patch.

Outi’s picture

Outi CreditAttribution: Outi commented
Status: Needs review » Reviewed & tested by the community

I tested it and it works fine for me.

  • MiSc committed c445347 on 6.x-1.x authored by fgm 
    Issue #1358276 by fgm, helmo: hook_requirements adds '0' key in return...
MiSc’s picture

MiSc CreditAttribution: MiSc commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed to latest dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.