Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I fiexed submit handlers
Comment | File | Size | Author |
---|---|---|---|
fix_filtering.patch | 4.18 KB | benys |
Comments
Comment #1
Pasqualle$form_state['values']['op'] == t('Filter')
checking the UI string value seems like a wrong pattern to me.. The developer should always use the code (id), not the display value.
so I prefer checking the $form_state['triggering_element']['#id'].
if the id is not unique, like the edit-filter vs edit-filter--2, then the id should be renamed to tt-filter or something..
otherwise the patch seems good..
Comment #2
benys CreditAttribution: benys commentedI thought the same, but I checked how it is done in other filter forms :-). http://api.drupal.org/api/drupal/modules--node--node.admin.inc/function/...
Comment #3
Pasqualleyes, I know, core has some coding style problems..
some other ways used in core to get the clicked button:
http://api.drupal.org/api/drupal/modules--field_ui--field_ui.module/func...
http://api.drupal.org/api/drupal/modules--field_ui--field_ui.admin.inc/f...
http://api.drupal.org/api/drupal/modules--file--file.module/function/fil...
http://api.drupal.org/api/drupal/modules--file--file.field.inc/function/...
http://api.drupal.org/api/drupal/modules--search--search.admin.inc/funct...
Comment #4
Pasqualle@benys are you interested to becoming a co-maintainer?
Comment #5
benys CreditAttribution: benys commentedI am interested :-).
would be the first drupal's project where I will be cooworker :-)
Comment #6
Pasqualleaccess granted, you can:
- push new code into the git repository
- assign issues to other maintainers
* Please do all the development in the issue queues, which means, create an issue before committing something into git. It is not obligatory to attach a patch to your issue, but if you start a bigger change we (maintainers) would like to know about it.
* If you need a new official release please create a new task. Dev releases are generated automatically (twice a day).
* If something is wrong or outdated on the project page, please create a new task.
* You can find me on IRC (freenode) #drupal-contribute, or send me an email through my contact form, and you will get my other contacts in reply.
Welcome on board, thank you for the help
Comment #7
dimitriseng CreditAttribution: dimitriseng commentedHi. The patch is fixing the issue with the content types not being filtered. It also seems to provide the same behaviour as before for the rest of the types as far as I can see. I guess it is a question of choosing the prefered style.
One issue with the patch is that it removes the closing "*/* in the comments under the line "* Submit handler for the taxonomy translation form.", which is causing an issue.
Can you please confirm the prefered style and fix the issue with the closing comment? Thank you.
Comment #8
dimitriseng CreditAttribution: dimitriseng commentedThe patch is working ok, any update on this? Please see my comments in #7, thank you.
Comment #9
Pasquallethis should be fixed in the next dev release
Comment #10
dimitriseng CreditAttribution: dimitriseng commentedI can confirm that this is working with the latest dev. Thank you Pasqualle!