As proven with a review there are some problems with the UI of the More like this blocks and essentially the generic Solr Search block
This label is really hard to scan, what does this mean? In addition to that, why is this in a fieldset? Is it really not important?
This information is kinda useless. This should be a table, informing where the block is, and a link to edit it.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 1356038.patch | 46.42 KB | nick_vh |
| #5 | 1356038.patch | 41.25 KB | nick_vh |
| #3 | 1356038.patch | 41.26 KB | nick_vh |
| #2 | 1356038.patch | 35.03 KB | nick_vh |
| #1 | Apache Solr search | Smartphone compare-6.jpg | 82.1 KB | nick_vh |
Comments
Comment #1
nick_vhAnd some results of the re-factoring!
This opens also the path for more generic apache solr blocks
Comment #2
nick_vhImproved patch, also handles the delete link in the block listing + a renderable array for the block itself
Comment #3
nick_vhAnd the blocks are also working now
Moved everything over to apachesolr_search module since this is a search part and not a core apachesolr function.
Comment #4
pwolanin commentedMinor, but I'd take out 'Search' before "More Like This", and I'm not sure we need the quotes?
Comment #5
nick_vhThe quotes are imho needed to avoid confusion between the interface text and the type.
If you remove the quotes you also have to remove the camelcasing, and that would not be UI friendly.
The best way, but that is for the future is to remove the more like this from the UI and just add a link to Add Search Block. This link should take you to a page where you select the type of your block, similar to the search pages configuration.
Comment #6
nick_vhAnd now all the tests are also running
Comment #7
nick_vhAnd pushed it up to the repo. Have fun with renewed More like this blocks!
Comment #8
nick_vhComment #9.0
(not verified) commentedUpdated issue summary.