Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
It is not totally clear what Edit Meta Tags means.
So if
/**
* Implements hook_permisson().
*/
function metatag_permission() {
$permissions['administer meta tags'] = array(
'title' => t('Administer meta tags.'),
'restrict access' => TRUE,
);
$permissions['edit meta tags'] = array(
'title' => t('Edit meta tags.'),
);
return $permissions;
}
was changed to below or something like it (minus the asterisks) it may make it easier to quickly grasp that setting?
/**
* Implements hook_permisson().
*/
function metatag_permission() {
$permissions['administer meta tags'] = array(
'title' => t('Administer meta tags.'),
'restrict access' => TRUE,
);
$permissions['edit meta tags'] = array(
'title' => t('Edit meta tags ****per Entity creation ie Node, Tag etc.****'),
);
return $permissions;
}
Comment | File | Size | Author |
---|---|---|---|
#5 | metatag-n1355990-5.patch | 816 bytes | DamienMcKenna |
#2 | metatag-n1355990-2.patch | 413 bytes | DamienMcKenna |
Comments
Comment #1
marcoka CreditAttribution: marcoka commentedComment #2
DamienMcKennaThanks for pointing this out, and you are quite correct, the current description is a bit confusing.
A small note about issue queue etiquette: please don't change an issue's status to "needs review" until there is an actually patch file to review, like this one :)
Comment #3
DamienMcKennaThis will do for now. Committed. Thanks for pointing this out.
Comment #4
Dave ReidThis should go in the description of the permission, not the title. Titles should be short but efficient as possible.
Comment #5
DamienMcKennaAh. Sorry for forgetting about the 'description' argument.
Comment #6
DamienMcKennaCommitted.
Comment #8
yurtboy CreditAttribution: yurtboy commentedthanks!