It is not totally clear what Edit Meta Tags means.
So if

/**
 * Implements hook_permisson().
 */
function metatag_permission() {
  $permissions['administer meta tags'] = array(
    'title' => t('Administer meta tags.'),
    'restrict access' => TRUE,
  );
  $permissions['edit meta tags'] = array(
    'title' => t('Edit meta tags.'),
  );
  return $permissions;
}

was changed to below or something like it (minus the asterisks) it may make it easier to quickly grasp that setting?

/**
 * Implements hook_permisson().
 */
function metatag_permission() {
  $permissions['administer meta tags'] = array(
    'title' => t('Administer meta tags.'),
    'restrict access' => TRUE,
  );
  $permissions['edit meta tags'] = array(
    'title' => t('Edit meta tags ****per Entity creation ie Node, Tag etc.****'),
  );
  return $permissions;
}
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

marcoka’s picture

Status: Active » Needs review
DamienMcKenna’s picture

FileSize
413 bytes

Thanks for pointing this out, and you are quite correct, the current description is a bit confusing.

A small note about issue queue etiquette: please don't change an issue's status to "needs review" until there is an actually patch file to review, like this one :)

DamienMcKenna’s picture

Status: Needs review » Fixed

This will do for now. Committed. Thanks for pointing this out.

Dave Reid’s picture

Status: Fixed » Needs work

This should go in the description of the permission, not the title. Titles should be short but efficient as possible.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
816 bytes

Ah. Sorry for forgetting about the 'description' argument.

DamienMcKenna’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

yurtboy’s picture

thanks!