IPE - multiple JS sort containers

Sorry, but I don't quite understand in which situation this happens. Maybe a screenshot could help?

Hm yeah, I've never had this happen myself. Maybe something weird with behaviors?

Can you reproduce it on a clean install?

Sorry to reopen an old issue, but this is the closest I found to the issue I'm seeing.

The problem is that panels_ipe.js's createSortContainers() seems to only work if the markup spitted by the region style directly consists of the draggable panes, with no surrounding markup.

If the region style adds wrapping markup, then:
- if the region is not empty, createSortContainer() produces *two* '.panels-ipe-sort-container ' divs.
- then bad things happen when you add a new block through IPE: the markup for the new block gets inserted twice (one for each 'panels-ipe-sort-container'),
- then on "Save" you get an "Integrity constraint violation: Duplicate entry for key PRIMARY: INSERT INTO {panels_pane}" error.

Easily reproduced with "list" region style, or any custom style created with Stylizer :
- Take a region that's not empty (or add a custom block in it, save)
- Switch the region style to "List / unordered", and save.
- Using the IPE, add a new custom block to the region --> The markup appears twice, once in the ul/li, once above
- Save --> "Integrity constraint violation" error.

Attached patch seems to do the trick :

- Makes sure that createSortContainers() targets the right 'panels-ipe-portlet-marker' (there is one per region + one per pane in the region, we want the one of the region), and thus does not create duplicate 'panels-ipe-sort-container' divs for each region

- After a new pane is created, makes best effort to insert the HTML at the "right" place within the wrapping markup for the region - that is, before the 1st existing pane in the region. If the region was empty so far, there's no way to find that "right" sport, insert it as a child of the 'panels-ipe-sort-container' div like current code does.
Won't always be perfect, for example, in the case of the "list / unordered" region style, the new pane will appear just before the former first pane but within the same <li>. But works fine for Stylizer or other 'simple div' based Styles.

Note: patch is against -dev, but was developped and tested against 7.x-3.3 only. Dunno if things have changed a lot in this area since then...

Clearer explanation:

   this.createSortContainers = function() {
     $('div.panels-ipe-region', this.topParent).each(function() {
-      $('div.panels-ipe-portlet-marker', this).parent()
+      $(this).children('div.panels-ipe-portlet-marker').parent()
         .wrapInner('<div class="panels-ipe-sort-container" />');

Current code works with "default" region style, because while there are several $('div.panels-ipe-portlet-marker', this), they are all siblings and thus have the same parent --> wrapInner() operates on a jQuery set with a single element, 'panels-ipe-sort-container' is added once.
That's not true anymore for region styles with wrapping markup: there are several $('div.panels-ipe-portlet-marker', this) with different parents --> several 'panels-ipe-sort-container' end up being created for the region.

Fixed the issue for me

I tested this patch a bit with Panopoly and things generally seem to work right. Anyone else have any feedback?

This patch is also being used and is working in Open Atrium 2.

Patch from #7 also resolved the issue for me. Thanks yched!

Tested and Fixed!

Commit here:
http://drupalcode.org/project/panels.git/commit/63cf629