I may be missing something very obvious but after clicking 'select media' the browser popup appears but there is no actual way to close the popup without pressing 'Esc' and I know A LOT of users wont realise that they have to click Esc if they want to close the popup without attaching any media.
Just something simple like a 'Cancel' button next to submit or 'Close' in the top left corner etc would be enough. If I get time i'll try to submit a patch but I'm sure someone who knows the code well will be able to add this in no time.
Adam
| Comment | File | Size | Author |
|---|---|---|---|
| #22 | media_close.png | 29.21 KB | milos.kroulik |
| #3 | beardfish.com screen capture 2011-11-30-12-13-30.png | 50.95 KB | noslokire |
Comments
Comment #1
oxford-dev commentedUpdate: just noticed that a cancel appears on the library tab but not the upload or web tabs.
Update: Turns out it can be fixed simply by replacing line 93 in includes/media.browser.inc from
if (!empty($plugin_output[$key]['form']['actions']) && !isset($plugin_output[$key]['form']['actions']['cancel'])) {
to
if (!empty($plugin_output[$key]['form'][0]['actions']) && !isset($plugin_output[$key]['form'][0]['actions']['cancel'])) {
and adding
#media-tab-upload #edit-actions input, #media-internet-add #edit-actions input{
float:left;
}
#media-tab-upload .fake-cancel, #media-tab-media_internet .fake-cancel{
margin-top:0px;
}
to media.css
The above works at least for the upload and web tabs. Perhaps there is a better solution
Comment #2
dave reidUsing the latest 7.x-2.x I can see the Cancel buttons just fine on all tabs.
Comment #3
noslokire commentedOurs disappeared on the latest dev version as well, we are having to press 'esc' to get out of it.
Doing the steps above fixed this as well, although I did not have to add the CSS.
I'll attach what we are seeing.
Comment #4
franzkewd commentedSame situation here. Agree with #1 and #3.
Comment #5
dave reidI still am not able to duplicate this with a fresh install of the latest Media 7.x-2.x-dev and using the core Seven theme as the admin theme.
I will need more specifics to help reproduce this:
- Are any other media-related modules installed?
- What theme are you using as the admin theme?
- What browser and version are you using when this happens?
Comment #6
franzkewd commentedHI Dave,
As requested, the following are installed on my system:
- Media related modules installed: File Entity 7.2.dev, Media 7.2.dev, Media Browser Plus 7.1.beta3, Media: Youtube 7.1.dev
- Theme: Adaptivetheme 7.2.1, Admin theme: Rubik 7.4.beta6
- Other modules: Mediafront 7.1.dev, Panels 7.3.alpha3
- Browser: Safari 5.1.2
Comment #7
rlmumfordI just noticed this as well,
Browser: Chrome 15.0.874.121
Media Related Modules installed: Media: Youtube.
Theme: Seven (Overlay turned off)
Using the popup from the WYSIWYG (ckeditor + wysiwyg module), don't know about it when using it as a Field Widget. Using the latest dev of media. The cancel button doesn't appear on 'Upload' or 'Web'.
Comment #8
szantog commentedThe way to reproduce in field widget, just go to field settings page, and on Enabled browser widget check in all, except the Library.
Comment #9
jorisx commentedsame here;
Library and View Library have the option to Submit or Cancel, Web has only a Submit
ps. esc is not working (safari)
Comment #10
circuscowboy commentedclean install of drupal 7.10, media --dev and file_entity --dev, views 3x
enabled mediafield, file_entity, media, views
added image - Media file selector to basic page.
No cancel button on upload screen.
Using stock everything including seven theme.
I hope this can get the needed attention as it presents a noticeable usability issue.
I moved it to bug report active because it can be reproduced on a stock install and is a bug.
Comment #11
dave reidPlease add what browser you are using.
Comment #12
circuscowboy commentedSame results on firefox 8.0.1 and chrome 16 - mac
If you know of a browser that should work please direct me.
Also checked ie 8 and 9 no cancel button on the upload screen.
And to be even more clear I dled all the modules fresh today with drush.
It always interesting when different people see different things. I am available to do any tests needed.
Comment #13
medden commentedMy post isn't constructive to fixing this issue, but wanted to say thanks to @circuscowboy for taking the time to provide such a thorough report on reproducing this issue.
I'm seeing the lack of cancel button in Firefox 8.0
Comment #14
leavellwd commented#1 worked for me.
however, what do I need to change in order to keep the "end" or the media browser from being cut off. It's not a huge deal, but it helps with style issues.
Comment #15
dave reidOk yay I am finally able to confirm this.
Comment #16
dave reidComment #17
dave reidThis is now fixed in 7.x-2.x with http://drupalcode.org/project/media.git/commit/3437f51. My apologies to everyone. I had some local modifications I was working on that I did not un-apply that had fixed this unintentionally.
Comment #18
aaron commentedit's not often you hear someone apologize for accidentally fixing an issue…
Comment #19
dave reidWell to be fair, it was the fact that I had the modification applied that I kept insisting that I wasn't able to reproduce. Finally clicked today that maybe it was those changes that actually fixed the issue... :)
Comment #20
circuscowboy commentedThanks Dave
I knew something would get worked out. It didn't make sense that it was environmental.
Persistance and patience is always key!
Comment #22
milos.kroulik commentedI still experience this problem in Media 7.x-2.0-unstable7+25-dev. It can be also seen by testing Media on simplytest.me (with Media as the only contrib module).
Comment #23
devin carlson commentedA cancel button is visible in the screenshot in #22.