Add aria landmark roles to Genesis [#1354114]

Comment #1

Jeff Burnz CreditAttribution: Jeff Burnz commented 6 December 2011 at 01:37

Status:

Active

» Postponed

Maybe, maybe not, this is a clean theme IMO, if you want them its easy enough to add.

Log in or register to post comments

Comment #2

mgifford

he/him

English

CreditAttribution: mgifford commented 6 December 2011 at 14:15

Genesis has to have good ARIA support to be accessible and semantically rich. There are lots of ways to do this as you know. In the xHTML stream it made sense to use jQuery to insert them as you described here http://drupal.org/node/460898

I'm assuming that the W3C's HTML5 Conformance Checker will be better able to handle landmark roles http://validator.w3.org - javascript addition of aria was largely introduced because validators were throwing errors http://www.standards-schmandards.com/2009/wai-aria-landmark-role-patterns/

The role of a starter theme as I see it (having never built one before) is to get people off to developing their new themes quickly and to ensure that they have a base which embodies the best practice of the Drupal community to build from. I don't see that adding aria makes the theme more dirty.

Log in or register to post comments

Comment #3

Everett Zufelt CreditAttribution: Everett Zufelt commented 6 December 2011 at 15:21

@Jeff

I am not really familiar with this theme. Can you please explain what you mean by "clean theme"? IMO there is nothing unclean about using WAI-ARIA roles in HTML5

Log in or register to post comments

Comment #4

Jeff Burnz CreditAttribution: Jeff Burnz commented 8 December 2011 at 19:26

What I mean by clean is that this theme doesn't do very much, it doesn't add anything or take much away. Its just very "strait" in terms of the output, now, I start adding more stuff and I have an extra overhead I need to maintain.

You want it in, fine, cut a patch, test it and offer to maintain it.

And guys, I don't need a freaking lecture. Sheesh.

Log in or register to post comments

Comment #5

mgifford

he/him

English

CreditAttribution: mgifford commented 8 December 2011 at 20:03

Sorry Jeff that all makes sense...

I think I'm no heavily invested enough in Genesis that it would make sense to offer to be a co-maintainer if it would help. Certainly for the HTML5 version. I don't have anywhere near your theming/design skills, but we're using the theme a lot and have other theming skills in-house..

And ya, it's also always totally fair to ask for a patch.

Log in or register to post comments

Comment #6

Jeff Burnz CreditAttribution: Jeff Burnz commented 8 December 2011 at 20:55

Yeah, sure, sorry to get a bit snippy, but i have a mountain of contrib code to maintain, and single styled themes that have 3 times as many users as this theme, and a core initiative, and 3 others to track closely on a weekly basis that impact mine. Short story - very busy, lower priority issue = probably maybe won't get done. If I find some time, then it will, but can't promise.

Log in or register to post comments

Comment #7

mgifford

he/him

English

CreditAttribution: mgifford commented 8 December 2011 at 21:20

Hey, just the core initiative alone is enough of a huge initiative to be involved in over the next 2 years. The AdaptiveTheme is also a much more heavily branded part of your business. Totally makes sense that this is the priority.

That being said, I'm willing to take on more of a supportive maintainer role to see that this project doesn't stall. I think the HTML5 stuff in Genesis is a great starting theme for other projects so want to see that the issue queue is being addressed.