page_manager_page_subtask_argument_ajax calls page_manager_page_form_argument with a non-existant form variable.

page_manager_page_form_argument($form, $clone_state);
$form = drupal_build_form('page_manager_page_form_argument', $form_state);

That's a pretty weird hunk, I have no idea what's actually happening there.

CommentFileSizeAuthor
#3 ctools-1353956-3.patch583 bytestim.plunkett
#1 ctools-1353956-1.patch566 bytestim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new ctools-1353956-1.patch566 bytes

This removes the notice, but I think this bit needs some comments, or a fix.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Needs work 
+++ b/page_manager/plugins/tasks/page.admin.incundefined
@@ -1056,6 +1056,7 @@ function page_manager_page_subtask_argument_ajax($step = NULL, $task_name = NULL
     page_manager_page_form_argument($form, $clone_state);

I don't understand the purpose of this line, since $clone_state doesn't seem to be modified, and the return value isn't captured.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new ctools-1353956-3.patch583 bytes

Hm, I think this looks right.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Fixed

http://drupalcode.org/project/ctools.git/commit/88c53ec

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.