The webform_update_6329() function is not returning the $ret variable, which will cause an array_merge() warning when update.php is run. Related but not high priority, the update function should be before the _webform_recursive_delete() function, not after it.

CommentFileSizeAuthor
#1 webform_missing_ret.patch1.67 KBquicksketch
webform_missing_ret.patch1.67 KBquicksketch

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Fixed
StatusFileSize
new webform_missing_ret.patch1.67 KB

Tested and confirmed working. Committed to the 6.x-3.x branch.

quicksketch’s picture

quicksketch
he/him
commented
Title: webform_update_6329() missing return $ret, causes error on updates » Move webform_recursive_delete() to the bottom of webform.install
Category: bug » task
Priority: Normal » Minor

Oh, vernond already fixed this issue in #1265758: webform_update_6329 does not return $ret. Well I've switched the position of _webform_recursive_delete() nonetheless.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.