I ended up cleaning up a few issues & putting them into a big patch.
#1062624: Links to config
#1129902: Fatal errors Undefined index, Argument #1 is not an array in antispam_comment_view, Cannot use string offset as an array

Plus bringing this all through coder. There are still some issues with coder, but they really need to be reviewed by someone who knows the module better.

CommentFileSizeAuthor
#6 antispam-n1349574-6.patch127.62 KBDamienMcKenna
#5 antispam-n1349574-5.patch127.98 KBDamienMcKenna
#1 antispam-coder-fatal-error-link-2.patch72.32 KBmgifford
antispam-coder-fatal-error-link.patch72.32 KBmgifford
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
FileSize
antispam-coder-fatal-error-link-2.patch72.32 KB

fixed bad typo

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

Let's see if it still applies.

Status: Needs review » Needs work

The last submitted patch, antispam-coder-fatal-error-link-2.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Issue summary: View changes

Marked #2164347: Antispam causes an Error message when posting a comment as a duplicate.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs work » Needs review
FileSize
antispam-n1349574-5.patch127.98 KB

This is rerolled, and excludes the patch for #1129902: Fatal errors Undefined index, Argument #1 is not an array in antispam_comment_view, Cannot use string offset as an array which was already fixed in #1483796: AntiSpam fatal error when posting comments., plus a whole bunch of comment formatting fixes for antispam.module.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
FileSize
antispam-n1349574-6.patch127.62 KB

I've removed the change to antispam.info, lets leave that in #1062624: Links to config.

Everett Zufelt’s picture

Everett Zufelt CreditAttribution: Everett Zufelt commented

Hi Damien

I don't have any time to maintain this module. If you would like ping me and I can give you maintainer status.

Thanks

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Fixed

Committed!

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)
Issue tags: +Needs backport to D6

Needs to be backported to D6.

cfinke’s picture

cfinke CreditAttribution: cfinke commented
Status: Patch (to be ported) » Closed (won't fix)

Closing, as D6 compatibility is no longer a priority.