The menu structure generated by the module at /sitemap cannot be modified at all. This makes it impossible for other modules to jump in.

For example, Special Menu Items adds two new tokens on top of ( and ). Adding a hook would enable this module or a glue module to avoid these entries to generate a non existent link.

CommentFileSizeAuthor
#3 1349202_add_hook_sitemap_menu_tree_alter_3.patch538 bytesjuampynr
#2 1349202_add_hook_sitemap_menu_tree_alter_2.patch638 bytesjuampynr
#1 1349202_add_hook_sitemap_menu_tree_alter.patch638 bytesjuampynr

Comments

juampynr’s picture

juampynr commented
StatusFileSize
new 1349202_add_hook_sitemap_menu_tree_alter.patch638 bytes

Attaching patch to be reviewed.

Here is an example of how Special Menu Items could make links to <nolink> to point to the sitemap page:

  /**
   * Implements hook_site_map_menu_tree_alter
   *
   * Removes wrong URLs for special_menu_item paths
   */
  function mymodule_site_map_menu_tree_alter($menu_display) {
    foreach ($menu_display as $id => $item) {
      if (isset($item['#href']) &&
        ($item['#href'] == '<nolink>' || $item['#href'] == '<separator>')) {
          $menu_display[$id]['#href'] = 'sitemap/#';
      }
    }
    return $menu_display;
  }
juampynr’s picture

juampynr commented
StatusFileSize
new 1349202_add_hook_sitemap_menu_tree_alter_2.patch638 bytes

Attaching an improved patch with right paths in the diff.

juampynr’s picture

juampynr commented
StatusFileSize
new 1349202_add_hook_sitemap_menu_tree_alter_3.patch538 bytes

Sorry, uploaded the same one. Here it is.

darrell_ulm’s picture

darrell_ulm commented
Priority: Major » Normal

Looks interesting.

Hey offhand, can anyone tell me if there are possible security implications for this?

Just checking.

juampynr’s picture

juampynr commented
Issue tags: +Needs security review

Here is the related issue on Special Menu Items: #1104940: filter out Special menu items from xml sitemap.

The risk of adding a hook would depend entirely on what the module that hooks in does, but it does not add any security breach by itself. However, I have added the tag Needs Sec Review to this issue.

webadpro’s picture

webadpro commented

Has this been commited yet?

juampynr’s picture

juampynr commented

No.

arpieb’s picture

arpieb commented

Missed this issue in my search - a more complete and Drupal-standard way to invoke the alter implemented in the patch in #1588988: Add alter hook for menu tree prior to rendering.

darrell_ulm’s picture

darrell_ulm commented
Status: Needs review » Closed (duplicate)

Based on http://drupal.org/node/1349202#comment-6030258 closing out due to duplicate patch at http://drupal.org/node/1588988.