When using the entity Row style plugin for displaying the results as entities, the render method of the handler is expecting an array of entities keyed by entities ids.

CommentFileSizeAuthor
#5 1348514-entities-array-keyed-by-entities-ids.patch931 bytesjsacksick
#1 1348514-entities-array-keyed-by-entities-ids.patch0 bytesjsacksick

Comments

jsacksick’s picture

jsacksick commented
StatusFileSize
new 1348514-entities-array-keyed-by-entities-ids.patch0 bytes

For now, the entities array is updated in the view method in the commerce_controller.inc file.

jsacksick’s picture

jsacksick commented
Status: Active » Needs review
rszrama’s picture

rszrama commented
Category: bug » feature
Status: Needs review » Active

Hmm, the patch you uploaded was empty. : )

damien tournoud’s picture

damien tournoud commented
Category: feature » bug

This is actually a bug report. This has been fixed (at least partially) in the Entity API controller, but not in ours.

jsacksick’s picture

jsacksick commented
StatusFileSize
new 1348514-entities-array-keyed-by-entities-ids.patch931 bytes

Sorry ... ! I don't know what happened ! That's a quick dirty patch ...

rszrama’s picture

rszrama commented

Ahh, I see. Without the patch I didn't know where the problem actually was. : )

rszrama’s picture

rszrama commented
Status: Active » Needs review

Queuing the patch for testing.

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Alrighty, we have confirmation that this fixes things, and I was able to jimmy a test together locally to confirm it. I rewrote the patch to build the new entities array in an entirely separate variable. Imagine if the $entities array had entities keyed 1, 2, 3 and the entity with the key of 1 was rekeyed to 3. I also don't particularly care for falling back to the existing delta value in the event that we can't determine an entity's actual ID Key, but I suppose it's safe since this is likely to never happen and if it does none of the entities in the array should have that key.

Commit: http://drupalcode.org/project/commerce.git/commitdiff/9340c34

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.