Remove verbose logging on successful 'exec' calls [#1347594]

Currently, every test log includes a complete list of drupal tests at the bottom, added by the following code:

    // Get test info for use by test_info_parse().
    if (!$this->exec(PIFR_CLIENT_PHP . ' ./' . $run_tests . ' --php ' . PIFR_CLIENT_PHP . ' --url ' . $url . ' --list')) {
      $this->set_error(array('@reason' => t('failed attempting to get list of tests from run-tests.sh')));
      return;
    }

I don't understand why this is here, or what test_info_parse() actually does (or whether it's even needed) ... but it seems to me that this each test should logically only care about the tests it's executing.

The following patch adds the $test_list variable to the command being executed, which should limit the output to only those tests which are relevant to the run.

Comment	File	Size	Author
#9	pifr_remove-verbose-logging-on-exec-success-1347594-9.patch	2.73 KB	jthorson
#8	pifr_remove-verbose-logging-on-exec-success-1347594-8.patch	2.73 KB	jthorson
#4	1347594-4.patch	2.73 KB	jthorson
	pifr.do_not_output_core_tests_in_log.patch	795 bytes	jthorson

Comments

Comment #1

jthorson commented 12 January 2012 at 05:44

Status:

Needs review

» Fixed

Committed to 6.x-2.x (e166202).

Comment #2

26 January 2012 at 05:50

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #3

jthorson commented 7 February 2012 at 19:14

Status:

Closed (fixed)

» Needs work

We're still getting the full list on (at least) contrib branch tests.

Comment #4

jthorson commented 21 February 2012 at 07:06

Title:	Only include relevant tests in run_tests --list output	» Remove verbose logging on successful 'exec' calls
Status:	Needs work	» Needs review

Status	File	Size
new	1347594-4.patch	2.73 KB

Attached patch removes the extra verbosity when 'exec' calls are successful, but allows this to be over-ridden via an added parameter on the actual exec definition. This parameter is used to keep successful output of the actual run-tests.sh run in the log, while stripping out extra gunk such as the run-tests.sh --list output.