$vocabulary = (object) array(
    'name' => st('Tags'),
    'description' => $description,
    'machine_name' => 'tags',
    'help' => $help,

  );
  taxonomy_vocabulary_save($vocabulary);

This is later used in creating the instance:

'description' => $vocabulary->help,

But taxonomy_vocabulary_save() isn't going to do anything with it, so it's a bit misleading to put it in the vocabulary object.

Comments

benjy’s picture

Assigned: Unassigned » benjy
StatusFileSize
new794 bytes

From what I can see the help is never used and therefore we should just remove it.

Patch attached.

benjy’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, removed-help-1346098-1.patch, failed testing.

benjy’s picture

Status: Needs work » Needs review
StatusFileSize
new1.25 KB

Updated. Missed the use of $vocab->help

chi’s picture

#4: removed-help-1346098-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, removed-help-1346098-1.patch, failed testing.

benjy’s picture

Status: Needs work » Closed (won't fix)

This issue is no longer relevant as it's been fixed elsewhere.

joachim’s picture

Version: 8.x-dev » 7.x-dev
Status: Closed (won't fix) » Active

It still surely applies to D7 though?

chi’s picture

Issue tags: +clean-up

Yes, it does.

benjy’s picture

Status: Active » Needs review
StatusFileSize
new1.18 KB

Yeah good point, forgot about D7. New patch attached.

chi’s picture

Status: Needs review » Reviewed & tested by the community

Works for me.

David_Rothstein’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.