See http://www.google.com/support/webmasters/bin/answer.py?answer=1708844

Add support for <link rel="publisher" href="https://plus.google.com/[yourpageID]" />

CommentFileSizeAuthor
#12 metatag-n1343914-12.patch2.09 KBdamienmckenna
#10 metatag-n1343914-9.patch2.28 KBdamienmckenna
#7 metatag-n1343914-5.patch2.98 KBdamienmckenna

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Fixed

Fixed with http://drupalcode.org/project/metatag.git/commit/8490b85

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Issue summary: View changes
Status: Closed (fixed) » Patch (to be ported)

Needs to be ported to D8.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I wonder if this should be moved into the Google Plus submodule instead of being part of the main module? Hrm.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Patch (to be ported) » Needs review
Parent issue: » #2741339: Plan for Metatag 8.x-1.0-beta10 release
StatusFileSize
new metatag-n1343914-5.patch2.98 KB

This adds it as a Google Plus meta tag.

What do you think Dave? Put it in the Google Plus submodule and then update the D7 branch, or put it in the main branch even though it's really only for Google Plus?

  • DamienMcKenna committed bc52fe4 on 8.x-1.x 
    Issue #1343914 by DamienMcKenna, Dave Reid: Added the (Google+)...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed
StatusFileSize
new metatag-n1343914-5.patch2.98 KB

Committed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Fixed » Patch (to be ported)

Need to move the meta tag to the Google Plus submodule on the D7 branch too.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new metatag-n1343914-9.patch2.28 KB

For consideration.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#2758749: Plan for Metatag 7.x-1.18 release

Want to get this into the next release so that it matches the D8 branch.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n1343914-12.patch2.09 KB

Rerolled.

Status: Needs review » Needs work

The last submitted patch, 12: metatag-n1343914-12.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

The last submitted patch, 7: metatag-n1343914-5.patch, failed testing.

  • DamienMcKenna committed 8afd3f3 on 7.x-1.x 
    Issue #1343914 by DamienMcKenna: Moved Publisher meta tag to GooglePlus...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tr-drupal’s picture

tr-drupal commented

Hello,

before the update to metatag-7.x-1.18 the publisher entry looked like this:

<link rel="publisher" href="https://plus.google.com/our_profile/" />

after the update it looks like this:

<link itemprop="" content="https://plus.google.com/our_profile/" />

Is this correct?

I've seen the hint about editing the html.tpl.php of the theme. I had to ask the author of the theme, because the example in the readme.txt of the google+ submodule looked differently.

In the theme it looked like this:

<!DOCTYPE html>
<!--[if lt IE 7]> <html class="ie ie6" lang="<?php print $language->language; ?>" dir="<?php print $language->dir; ?><?php if ($language->dir == 'rtl'){ echo "rtl"; } ?>"> <![endif]-->
<!--[if IE 7]> <html class="ie ie7" lang="<?php print $language->language; ?>" dir="<?php print $language->dir; ?><?php if ($language->dir == 'rtl'){ echo "rtl"; } ?>"> <![endif]-->
<!--[if IE 8]> <html class="ie ie8" lang="<?php print $language->language; ?>" dir="<?php print $language->dir; ?><?php if ($language->dir == 'rtl'){ echo "rtl"; } ?>"> <![endif]-->
<!--[if gt IE 8]> <!--> <html class="" lang="<?php print $language->language; ?>" dir="<?php print $language->dir; ?><?php if ($language->dir == 'rtl'){ echo "rtl"; } ?>"> <!--<![endif]-->

and according to the author it should be like this now:

<!DOCTYPE html>
<!--[if lt IE 7]> <html class="ie ie6" lang="<?php print $language->language; ?>" dir="<?php print $language->dir; ?><?php if ($language->dir == 'rtl'){ echo "rtl"; } ?><?php print $schemaorg; ?>"> <![endif]-->
<!--[if IE 7]>    <html class="ie ie7" lang="<?php print $language->language; ?>" dir="<?php print $language->dir; ?><?php if ($language->dir == 'rtl'){ echo "rtl"; } ?><?php print $schemaorg; ?>"> <![endif]-->
<!--[if IE 8]>    <html class="ie ie8" lang="<?php print $language->language; ?>" dir="<?php print $language->dir; ?><?php if ($language->dir == 'rtl'){ echo "rtl"; } ?><?php print $schemaorg; ?>"> <![endif]-->
<!--[if gt IE 8]> <!--> <html class="" lang="<?php print $language->language; ?>" dir="<?php print $language->dir; ?><?php if ($language->dir == 'rtl'){ echo "rtl"; } ?><?php print $schemaorg; ?>"> <!--<![endif]-->

I've made the change, but there wasn't any change in the resulting display of the publisher tag. It sill look as mentioned above, which doesn't look correctly to me, because the readme.txt of the Google+ submodule says:

The following Google+ tags are provided:

* itemprop:name
* itemprop:description
* itemprop:image

and none of these is set in my case.

Any idea what is going wrong?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

There's a fix in the current -dev release for this bug, it'll be in the next stable release.

tr-drupal’s picture

tr-drupal commented

I've installed the version "metatag-7.x-1.19" now and am wondering, if it's correct, that the publisher entry looks as it did before the update to "metatag-7.x-1.18", i.e.:

<link rel="publisher" href="https://plus.google.com/our_profile/" />

I thought it should looke like this now, after it was moved to the Google+ sub-module:

<link itemprop="name" content="https://plus.google.com/our_profile/" />

i.e. that the update would fix the missing itemprop tag.

Just want to be sure, if the first code is correct or not.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

@tr-drupal: No, you still use the "Publisher" meta tag, it was just moved to the "Google+" group instead of the "Advanced" group, and its output is exactly the same as it used to be (excluding the bug in 1.18 where it was broken).