Merge "list terms" page into "edit vocabulary" page

See also: #394518: Merge Term add page and vocabulary overview.

See also: #631038: Add Manage Fields and Manage Display links to the vocab dropbutton

Earlier this week I worked on #2421011: Make shortcut add and edit form titles better. This is WIP patch complete untested only made code changes.

Voila

Whoa, awesome! That was fast.

+1 for this change generally; I personally click on the wrong thing all the time when I try to use this form. I'd like to get a quick usability assessment on the screenshot in #5 so we have some guidance on whether to proceed.

Maybe not related, but why isn't the "Add Term" button in the screenshot that blue one? In HEAD it is blue.

At #7 nothing wrong with the patch my local install has this error.
Warning: include_once(core/themes/seven/seven.theme): failed to open stream: No such file or directory in Drupal\Core\Extension\Extension::load() (line 145 of core/lib/Drupal/Core/Extension/Extension.php).

For reference, updating the summary to show what HEAD is like (with two different forms).

Also corrected the beta evaluation. It's not unfrozen--only CSS, strings, tests, etc. are unfrozen. It is however prioritized as a usability issue. Also corrected the disruption section with what I know without doing a code review; it's very common to alter this UI in contrib so this would break modules doing that.

And just moving the beta eval above the fold. :)

Oh, I think maybe the "Add Term" button should also come between the vocabulary fields and the ordering sections; it's a little confusing at the top as it's away from the list of terms. Looking at https://www.drupal.org/files/Screen%20Shot%202013-02-01%20at%208.13.59%2... that was what was done in #663946: Merge "List links" page into "Edit menu" page as well.

Some more work.

• Found a bug on Vocabulary listing page add term link was pointing to add vocabulary fixed it added assert. I'll move it to a separate issue.
• Fixed Reset Button issue.
• Removed/replaced overview-form, overview_form references.
• Re-add \Drupal\taxonomy\Form\OverviewTerms because \Drupal\forum\Form\Overview uses it.

It seems like the last patch just duplicates code, not moves it?

It seems like the last patch just duplicates code, not moves it?

Yeah can't remove the \Drupal\taxonomy\Form\OverviewTerms yet because \Drupal\forum\Form\Overview is extending it so I have to copy the code.

What about putting it in a trait? Or inlining the other copy to forum.module?

Duplicating the UI is way worse than duplicating the code (which is bad too!).

Found a bug on Vocabulary listing page add term link was pointing to add vocabulary fixed it added assert. I'll move it to a separate issue.

Created #2465425: Vocabulary listing missing add taxonomy term link for that.

Honestly this has created so many usability issues on menu pages, I dont think this is actually the good practice.

Hm I am not sure this is good to unilaterally make wontfix; maybe we should explore other design options? This was originally designed as a usability improvement.

Moving to 8.1.x and postponing on the outcome of #2520232: Separate the menu settings from the 'add link' button.

#2520232: Separate the menu settings from the 'add link' button has resolved with a reasonable generic solution for these cases. Ideally this case should use the same solution.

Merging the "edit vocabulary" functionality and "list terms" on one page is not a good idea because it would cause other usability issues.

First of all: we loose the two different operators that clearly let the user choose between listing all terms and editing the vocabulary as such. For menus we have now ended up with the usability problem that there is no operator and no quick link for a user who wants to access the list of menu items: that's now hidden under "Edit menu".

Secondly: In a default Drupal installation, there really is in fact only the Vocabulary name and description under "Edit". But on a multilingual site the Edit page also contains the configuration about the Vocabulary language and whether terms can be translated. This is a configuration of the vocabulary as such and should not be mixed up with a list of terms.

Third: In many cases, a user role should have the permissions to add taxonomy terms, but not to rename the vocabulary. If we merge this, then users still need to go to "Edit vocabulary" when they have no permission to do so, and when the task at hand is to add a term to the list.

Sorry, I forgot the screenshot for the previous comment

That's additional configuration for a vocabulary on a multilingual site that lives on the Edit page.

Thanks @ifrik for your leadership and thoughtfulness on these issues.

Let's postpone this issue on an overall issue to design and validate better UIs for these configure/list/etc. admin UIs that have multiple actions. See #2520232: Separate the menu settings from the 'add link' button for a starting point. We can incorporate the discussion from this issue as well, but we need someone's help to summarize the overall issue so the discussion does not continue to fragment.

Thanks!