Currently the splash page will only work if clean URLs are enabled and configured properly. Otherwise, upon install, user will get a page not found error.

This URL is set through some inline JavaScript code added by martplug_splash module:

jQuery(document).ready(function() { document.location.hash = "overlay=martplug/splash"; });

Some logic needs to be added to handle the clean URL not being enabled case. I think there's a proper pattern for this, either in core or contrib.

CommentFileSizeAuthor
#2 observed after MartPlug site configuration355.03 KBjoao.parana
#2 We should watch it!52.31 KBjoao.parana
#1 1337420.patch893 bytesrecidive

Comments

recidive’s picture

recidive commented
Status: Active » Needs review
StatusFileSize
new 1337420.patch893 bytes

This patch should fix this issue. Needs testing.

joao.parana’s picture

joao.parana commented
Status: Needs review » Postponed
StatusFileSize
new We should watch it!52.31 KB
new observed after MartPlug site configuration355.03 KB

I did the test on my local machine and the "page not found"  error no longer occurs, but the MartPlug splash page was not loaded in the overlay.  Seems there is an error in drupal core related to lack of support for overlay when apache is not configured properly with mod_rewrite - see http://drupal.stackexchange.com/questions/4927/url-encoding-in-admin-ove...

Apparently the issue http://drupal.org/node/685790 was incorrectly closed.