http://qa.drupal.org/pifr/test/130769 - tests are broken again.

I'm going to set up a notification email...

CommentFileSizeAuthor
#6 commerce.fix_mode_1332394_05.patch167 bytesrfay
#1 1332394.test_permission.patch765 bytesrszrama

Comments

rszrama’s picture

rszrama commented
Status: Active » Needs review
StatusFileSize
new 1332394.test_permission.patch765 bytes

Ahh, I split 'administer commerce_order entities' into that and 'configure order settings' but didn't update the base test class to grant 'configure order settings' to store administrator roles. Activate test bot, engage!

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Local test run completed all clear first.

Commit: http://drupalcode.org/project/commerce.git/commitdiff/8354970

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Nicely done. And you and I now get email when it's broken. A little perk of managing the testing system :-) Hope we can have that for everybody that wants it at some point.

rszrama’s picture

rszrama commented

Awesome. Thanks for setting that up.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Fixed » Needs review

Hi Ryan - In the commit in #2 (83549) you changed the mode of modules/product_reference/commerce_product_reference.module to make it executable.

Could you please do a 

git config core.filemode false
git config --global core.filemode false

Reference: git help config or http://stackoverflow.com/questions/1580596/how-do-i-make-git-ignore-mode...

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
StatusFileSize
new commerce.fix_mode_1332394_05.patch167 bytes

Forgot the patch. It won't take long to review this one.

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.