Fix "disable question links to node" - output plain text instead of a link

The reason that you still get a link is so that someone knows that they can click on it and when they do; Depending on how FAQ is configured something will happen. A lot of the time it will expand the answer below the question when you click the question Or it can take you to the node Or it can be a jump menu and take you further down the page.

However all of these different configurations need to have the question as a link especially the hide/show the answer with javascript or else you would think it's just a list of questions w/o answers.

What about the checkbox that says:

Disable question links to nodes
This allows the user to prevent the questions being links to the faq node in all layouts except "Clicking on question opens the answer in a new page".

Well I haven't selected "Clicking on question opens the answer in a new page" and yet they are still displayed as links. Links that go nowhere and do nothing. Surely that checkbox is supposed to do what it says and disable the links - which it does not do.

Thank you for the update. I will check into that asap

Scenario #1a
Questions are set to: 'Questions inline'
Disable question links to nodes NOT checked

This works as expected. The Question and Answer are displayed and if you click the question it will take you to the proper node.

Scenario #1b
Questions are set to: 'Questions inline'
Disable questions links to nodes IS checked

This doesn't work as expected. The Question and Answer are displayed (that's fine) however the Question is still a link but it links back to the faq-page.

This should do the following. The Question and Answer should be displayed as they currently are but make the Question just a span tag instead of a link.

Scenario #2a
Questions are set to: 'Clicking on question takes user to answer further down the page '
Disable question links to nodes NOT checked

This works as expected. The Questions are listed in a ul at the top of the page and if clicked it takes you further down the page to the proper Question/Answer set. The Question link in the "Question/Answer set" takes you to the node as expected.

Scenario #2b
Questions are set to: 'Clicking on question takes user to answer further down the page'
Disable questions links to nodes IS checked

Same issue as stated in Scenario #1b the link should be changed to a span.

Scenario #3a and #3b
Disable question links to nodes

This option honestly shouldn't be here because the Javascript is always going to hide/show the answer it will never take you to the node.

However if you do want a read more link for this you need to check two checkboxes one for answer teaser and another to show node links.

Scenario #4
Questions are set to: 'Clicking on question opens the answer in a new page'

When this particular one is selected you can not check the checkbox for 'Disable questions links to nodes' for obvious reasons.

I believe this sums up all the issues that I see with the configuration issues. Please review and see if your Scenario isn't stated. If it is not please tell me the Scenario so I can test that and also have it on the list of todos.

You might also want to check out the following issue. This should also help on the confusion of what you can and can't do per Question display. #1344300: Revamp the FAQ Configuration Page

Good job. My scenario is described exactly in #1b, and your proposed solution is what I would expect should happen in that case.

"disable question links to node" should output plain text & should also still be operable when using expanding questions (javascript link not plain text). it is still not working as of today

I apologies for the lack of attention this issue has gotten. The company I work for put me on a huge project shortly after so I've been pretty busy. I will make a patch eventually. If someone else can that would be helpful too. Sorry for the delay.

Scenarios 1b and 2b fixed in D6 and D7 dev versions. Scenarios 3a and 3b are needed so the users know to click on the links to hide/show the answer underneath and so not to break the javascript. There's probably a way around it, if anyone is willing to work on a patch.