views_content_plugin_display_ctools_context needs a small patch to take advantage of the new customizable link_url that was just committed to views. This is an awesome feature since it lets us put a search box on any page and forward it to a view with the search term applied.

CommentFileSizeAuthor
#4 ctools-custom-url-panels-pane-1329776-4.patch1.12 KBJorrit
override_path.patch729 bytesEclipseGc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
Status: Needs review » Fixed

committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Jorrit’s picture

Jorrit CreditAttribution: Jorrit commented
Status: Closed (fixed) » Active

Should the same be done for views_content_plugin_display_panel_pane ?

Jorrit’s picture

Jorrit CreditAttribution: Jorrit commented
Status: Active » Needs review
FileSize
ctools-custom-url-panels-pane-1329776-4.patch1.12 KB

Please see the attached patch.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented 
if ($this->get_option('link_display') == 'custom_url' && $override_path = $this->get_option('link_url'))

Assignments during if() are generally bad, but sometimes I'll resort to them; but never if there's multiple conditions. Let's not do that, it's tricky to read and could one day cause bugs if somebody 'fixes' it.

Jorrit’s picture

Jorrit CreditAttribution: Jorrit commented

I know, but this is the way this specific feature is handled both in views_content_plugin_display_ctools_context and in Views itself, I just copied the feature over. I thought it was best just to keep this the same. Want me to make a new patch?

  • EclipseGc committed ea5ce0a on 8.x-2.x 
    #1329776 updating the context display plugin to work with the new...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Assigned: EclipseGc » Unassigned
Issue summary: View changes

EclipseGc: Any update for the D7 branch?

DamienMcKenna queued 4: ctools-custom-url-panels-pane-1329776-4.patch for re-testing.

  • EclipseGc committed ea5ce0a on 8.x-3.x 
    #1329776 updating the context display plugin to work with the new...