Problem/Motivation

Some of the descriptions of fields could be a bit better

Proposed resolution

Patch includes many text changes - also minor ordering changes on a field group

Remaining tasks

None

User interface changes

None

API changes

None

CommentFileSizeAuthor
#12 metatag-n1328562-12.patch9.32 KBDamienMcKenna
#11 metatag-n1328562-11.patch8.96 KBDamienMcKenna
#7 metatag-improve-descriptions-1328562-7.patch7.64 KBGreg Boggs
#2 improve_field_descriptions_1328562_2.patch8.96 KBandremolnar
#1 improve_field_descriptions_1328562_1.patch8.96 KBandremolnar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andremolnar’s picture

andremolnar CreditAttribution: andremolnar commented
FileSize
improve_field_descriptions_1328562_1.patch8.96 KB

Patch here for your reading pleasure

andremolnar’s picture

andremolnar CreditAttribution: andremolnar commented
FileSize
improve_field_descriptions_1328562_2.patch8.96 KB

Updated patch with minor typo type fixes

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Version: » 7.x-1.x-dev
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, improve_field_descriptions_1328562_2.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented

Needs a re-roll. Also, follow #1751276: Improve meta tags form usability.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Component: Code » User interface
Greg Boggs’s picture

Greg Boggs
he/him
Primary language English
Location Portland Oregon
CreditAttribution: Greg Boggs commented
Assigned: Unassigned » Greg Boggs
Issue summary: View changes
Status: Needs work » Needs review
FileSize
metatag-improve-descriptions-1328562-7.patch7.64 KB

I've rerolled this patch.

Given the age of this thread, I'm not certain all these changes are wanted as is. But, this should give a starting place to move forward.

Assuming I did the reroll correctly.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Parent issue: » #1269728: META: Plan for Metatag 7.x-1.0 release
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Needs work

Needs a reroll.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Assigned: Greg Boggs » Unassigned
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs work » Needs review
FileSize
metatag-n1328562-11.patch8.96 KB

Updated.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
FileSize
metatag-n1328562-12.patch9.32 KB

Updated to show a different intro message on entity forms vs the configuration pages.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Fixed

Committed. Feel free to open another issue if you think the forms could be improved further.

  • DamienMcKenna committed 7583cdd on 7.x-1.x 
    Issue #1328562 by andremolnar, Greg Boggs, DamienMcKenna: Improved form...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.