Problem/Motivation

Make token titles that have child-tokens clickable

Proposed resolution

Minor modification to the javascript jquery.treeTable.js file to make the titles clickable

Remaining tasks

Code review needed

User interface changes

Text color change, as well as clickable text

API changes

None

CommentFileSizeAuthor
#7 clickable_token_titles_1328546_7.patch731 bytesmstef
#3 clickable_token_titles_1328546_2.patch749 bytesjswaby
#1 clickable_token_titles_1328546_1.patch731 bytesjswaby

Comments

jswaby’s picture

jswaby commented
StatusFileSize
new clickable_token_titles_1328546_1.patch731 bytes

patch that needs review..

Status: Needs review » Needs work

The last submitted patch, clickable_token_titles_1328546_1.patch, failed testing.

jswaby’s picture

jswaby commented
StatusFileSize
new clickable_token_titles_1328546_2.patch749 bytes

patch diffed against trunk..

jswaby’s picture

jswaby commented
Status: Needs work » Needs review

review code

Status: Needs review » Needs work

The last submitted patch, clickable_token_titles_1328546_2.patch, failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Could this maybe be contributed back to the parent library (https://github.com/ludo/jquery-treetable/issues)?

mstef’s picture

mstef commented
Status: Needs work » Needs review
StatusFileSize
new clickable_token_titles_1328546_7.patch731 bytes

Drush make failed to apply #2 as well. Here's another reroll.

chris matthews’s picture

chris matthews commented
Assigned: jswaby » Unassigned
Issue summary: View changes

The 7 year old patch in #7 to jquery.treeTable.js applied cleanly to the latest token 7.x-1.x-dev and if applicable still needs review.

clickable_token_titles_1328546_7.patch:10: trailing whitespace.
          var cellText = cell.text(); 
Checking patch jquery.treeTable.js...
Applied patch jquery.treeTable.js cleanly.