please use the drupal feed icon inside the sitemap. It looks really nicer and is something the user remembers...

CommentFileSizeAuthor
#8 site_map.url_.patch4.88 KBhass
#5 feed-icon-12x12-comment.png734 byteshass
#4 feed-icon-12x12.png552 byteshass
#3 site_map.feed-icon.patch6.19 KBhass

Comments

frjo’s picture

frjo commented

I like the feed icon Drupal uses, it's the closest we have to a standrad since Firefox as well as IE 7 is using it.

For list I find it difficult to use in a nice way, it tends to be a bit to big.

hass’s picture

hass commented

i know, let's resize it... no problem...

hass’s picture

hass commented
Status: Active » Needs review
StatusFileSize
new site_map.feed-icon.patch6.19 KB

Here is the patch that fixes this issue. The images are following. Put them both in a directory named "img".

Additional it fixes a XHTML validaion bug if the "site_map_message" is blank (don't hurt me for mixing this up...).

hass’s picture

hass commented
StatusFileSize
new feed-icon-12x12.png552 bytes

this is the feed icon in 12x12. place into "site_map/img" folder

hass’s picture

hass commented
StatusFileSize
new feed-icon-12x12-comment.png734 bytes

this is the feed icon for commented feeds in 12x12. place into "site_map/img" folder, too

frjo’s picture

frjo commented
Assigned: Unassigned » frjo
Status: Needs review » Postponed (maintainer needs more info)

Thanks hass! Committed a little modified version of your patch and the images to HEAD. Please try it out and report any issues here.

hass’s picture

hass commented
Status: Postponed (maintainer needs more info) » Needs work

thank you, changes look nice, too. i found one bug... i found this while developing, but missed to include :-(((.

All theme_site_map_feed_icons URLs needs url() function... if not all links are broken :-(.

Example:

theme('site_map_feed_icon', url("taxonomy/term/$term->tid/$rss_depth/feed"));
hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new site_map.url_.patch4.88 KB

here is a patch for the URL bug. Aside you missed to fix the CSS file... patch fixes both.

hass’s picture

hass commented

this patch was build in the same way like 

$block['content'] = theme('feed_icon', url($feedurl));

was build...

frjo’s picture

frjo commented

Committed to HEAD, the links should now be correct, thanks.

I decided to skip the css file altogether.

hass’s picture

hass commented

if you skip the css, you will have a background color definied, where it is not required... a color and font-size that is senseless, while you don't have text... makes no sense to keep it. And the padding with EM is better for many themes... and different platforms.

frjo’s picture

frjo commented

What I meant was that I don't think the site_map module needs a CSS file at all anymore. I have removed the call to drupal_add_css() in HEAD.

hass’s picture

hass commented

yes, ok.

frjo’s picture

frjo commented
Status: Needs review » Fixed
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)